Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 973813003: DevTools: NetworkPanel: Preview: do not try to show HTML as JSONP. (Closed)

Created:
5 years, 9 months ago by eustas
Modified:
5 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: NetworkPanel: Preview: do not try to show HTML as JSONP. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191295

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M Source/devtools/front_end/network/RequestPreviewView.js View 1 chunk +14 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
eustas
5 years, 9 months ago (2015-03-03 15:55:21 UTC) #2
pfeldman
lgtm
5 years, 9 months ago (2015-03-04 12:56:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973813003/1
5 years, 9 months ago (2015-03-04 13:54:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=191295
5 years, 9 months ago (2015-03-04 17:20:54 UTC) #6
pfeldman
5 years, 6 months ago (2015-05-27 09:18:53 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1148133004/ by pfeldman@chromium.org.

The reason for reverting is: See
https://code.google.com/p/chromium/issues/detail?id=492540.

Powered by Google App Engine
This is Rietveld 408576698