Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1148133004: Revert of DevTools: NetworkPanel: Preview: do not try to show HTML as JSONP. (Closed)

Created:
5 years, 7 months ago by pfeldman
Modified:
5 years, 7 months ago
Reviewers:
eustas
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of DevTools: NetworkPanel: Preview: do not try to show HTML as JSONP. (patchset #1 id:1 of https://codereview.chromium.org/973813003/) Reason for revert: See https://code.google.com/p/chromium/issues/detail?id=492540 Original issue's description: > DevTools: NetworkPanel: Preview: do not try to show HTML as JSONP. > > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191295 TBR=eustas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195965

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M Source/devtools/front_end/network/RequestPreviewView.js View 1 chunk +6 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pfeldman
Created Revert of DevTools: NetworkPanel: Preview: do not try to show HTML as JSONP.
5 years, 7 months ago (2015-05-27 09:18:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148133004/1
5 years, 7 months ago (2015-05-27 09:19:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=195965
5 years, 7 months ago (2015-05-27 09:19:58 UTC) #3
eustas
On 2015/05/27 09:19:58, I haz the power - commit-bot wrote: > Committed patchset #1 (id:1) ...
5 years, 7 months ago (2015-05-27 12:24:45 UTC) #4
pfeldman
> I'm quite sure that this revert is wrong. > The original CL touches only ...
5 years, 7 months ago (2015-05-27 12:32:55 UTC) #5
eustas
5 years, 7 months ago (2015-05-27 13:10:15 UTC) #6
Message was sent while issue was closed.
On 2015/05/27 12:32:55, pfeldman wrote:
> > I'm quite sure that this revert is wrong.
> > The original CL touches only XHR and only if their mime type is HTML.
> > Developers asked to see what error was send by server.
> 
> I did not find the bug it was fixing.
> 
> > In bug you've tried to fix the description of what is wrong it very common.
> And
> > most probably it is error on developers server (setting wrong mime).
> 
> There is no such thing as wrong mime type when we are talking about json (yes,
> in this case it is text/html), we should infer JSON-ability via parsing. Your
> check for being HTML via parsing will give false positives for any JSON
content.
> 
> > BUG: https://code.google.com/p/chromium/issues/detail?id=492540

Actually, XHR isn't always JSON. It may be XML, HTML, anything.
Agree - we should check by parsing.

But in the case of mime type == text/html almost any content is valid, as it
could be rendered as a page.

Powered by Google App Engine
This is Rietveld 408576698