change colorfilter to return an array of frag processors

change colorfilter to return an array of frag processors

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/cff10b21a9934afc540d121b493b204335829589

[reed1, 2015-03-03 13:40:04]

reed@google.com changed reviewers:
+ bsalomon@google.com, senorblanco@google.com

[reed1, 2015-03-03 13:40:05]

ptal

[reed1, 2015-03-03 13:40:10]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-03-03 13:40:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/973593002/40001

[commit-bot: I haz the power, 2015-03-03 13:40:53]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-03-03 19:40 UTC

[egdaniel, 2015-03-03 14:40:27]

egdaniel@google.com changed reviewers:
+ egdaniel@google.com

[egdaniel, 2015-03-03 14:40:28]

lgtm

[commit-bot: I haz the power, 2015-03-03 14:41:49]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/cff10b21a9934afc540d121b493b204335829589

[bsalomon, 2015-03-03 17:51:01]

https://codereview.chromium.org/973593002/diff/40001/include/core/SkColorFilt...
File include/core/SkColorFilter.h (right):

https://codereview.chromium.org/973593002/diff/40001/include/core/SkColorFilt...
include/core/SkColorFilter.h:149: virtual bool asFragmentProcessors(GrContext*,
SkTDArray<GrFragmentProcessor*>*) const {
Does this mean we always have to malloc for the common case of 1 processor? I
wonder if we could use SkSTArray, SkAutoSTArray, or something similar.

[Noel Gordon, 2015-06-09 17:29:02]

noel@chromium.org changed reviewers:
+ noel@chromium.org

[Noel Gordon, 2015-06-09 17:29:04]

https://codereview.chromium.org/973593002/diff/40001/src/effects/SkColorCubeF...
File src/effects/SkColorCubeFilter.cpp (right):

https://codereview.chromium.org/973593002/diff/40001/src/effects/SkColorCubeF...
src/effects/SkColorCubeFilter.cpp:367: return true;
If array was NULL (maybe doesn't happen in practice) looks to me like this code
memory leaks the GrFragmentProcessor* frag. Was that intentional?

[bsalomon, 2015-06-12 15:20:36]

https://codereview.chromium.org/973593002/diff/40001/src/effects/SkColorCubeF...
File src/effects/SkColorCubeFilter.cpp (right):

https://codereview.chromium.org/973593002/diff/40001/src/effects/SkColorCubeF...
src/effects/SkColorCubeFilter.cpp:367: return true;
On 2015/06/09 17:29:03, noel gordon wrote:
> If array was NULL (maybe doesn't happen in practice) looks to me like this
code
> memory leaks the GrFragmentProcessor* frag. Was that intentional?

Definitely not!

https://codereview.chromium.org/1182813002

[Noel Gordon, 2015-06-12 16:45:27]

On 2015/06/12 15:20:36, bsalomon wrote:

> On 2015/06/09 17:29:03, noel gordon wrote:
> > If array was NULL (maybe doesn't happen in practice) looks to me like this
code
> > memory leaks the GrFragmentProcessor* frag. Was that intentional?
> 
> Definitely not!

Ok thanks, I suppose you guys will fix it some time.

[bsalomon, 2015-06-12 16:56:18]

On 2015/06/12 16:45:27, noel gordon wrote:
> On 2015/06/12 15:20:36, bsalomon wrote:
> 
> > On 2015/06/09 17:29:03, noel gordon wrote:
> > > If array was NULL (maybe doesn't happen in practice) looks to me like this
> code
> > > memory leaks the GrFragmentProcessor* frag. Was that intentional?
> > 
> > Definitely not!
> 
> Ok thanks, I suppose you guys will fix it some time.

I landed a fix here: https://codereview.chromium.org/1182813002