Issue 1182813002: Don't leak fragment processor in SkColorFilter::asFragmentProcessors implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1182813002: Don't leak fragment processor in SkColorFilter::asFragmentProcessors implementations. (Closed)

Created:
5 years, 6 months ago by bsalomon

Modified:
5 years, 6 months ago

Reviewers:
reed1, Noel Gordon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Don't leak fragment processor in SkColorFilter::asFragmentProcessors implementations. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/a0f1a18b9d6cd60753502be95e2f0e3d13c0ae04

Patch Set 1 #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -0 lines)			Patch
M	src/effects/SkColorCubeFilter.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/effects/SkColorFilters.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/effects/SkColorMatrixFilter.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/effects/SkLumaColorFilter.cpp	View	1 chunk	+3 lines, -0 lines	1 comment	Download
M	src/effects/SkTableColorFilter.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182813002/1

5 years, 6 months ago (2015-06-12 15:20:18 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/a0f1a18b9d6cd60753502be95e2f0e3d13c0ae04

5 years, 6 months ago (2015-06-12 15:32:56 UTC) #3

Noel Gordon

5 years, 6 months ago (2015-06-12 17:51:00 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/1182813002/diff/1/src/effects/SkLumaColorFilt...
File src/effects/SkLumaColorFilter.cpp (right):

https://codereview.chromium.org/1182813002/diff/1/src/effects/SkLumaColorFilt...
src/effects/SkLumaColorFilter.cpp:131: SkDEBUGCODE(frag = NULL;)
That wink at <eol> is interesting ;)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages