Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 973513002: [Sync] Remove DropAttachments from AttachmentService and SyncData (Closed)

Created:
5 years, 9 months ago by maniscalco
Modified:
5 years, 9 months ago
Reviewers:
pavely
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Remove DropAttachments from AttachmentService and SyncData AttachmentService and SyncData no longer need to provide a drop method beecause model type code can drop attachments using its AttachmentStore. BUG= Committed: https://crrev.com/f9648891191bb34bce0a4c4d0110d82dc23b9ee6 Cr-Commit-Position: refs/heads/master@{#318981}

Patch Set 1 #

Patch Set 2 : Fix call count. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -114 lines) Patch
M sync/api/sync_data.h View 1 chunk +0 lines, -9 lines 0 comments Download
M sync/api/sync_data.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M sync/api/sync_data_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/attachments/attachment_service_impl.cc View 2 chunks +0 lines, -22 lines 0 comments Download
M sync/internal_api/attachments/attachment_service_proxy.cc View 3 chunks +0 lines, -31 lines 0 comments Download
M sync/internal_api/attachments/attachment_service_proxy_unittest.cc View 1 6 chunks +1 line, -23 lines 0 comments Download
M sync/internal_api/public/attachments/attachment_service.h View 2 chunks +0 lines, -13 lines 0 comments Download
M sync/internal_api/public/attachments/attachment_service_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M sync/internal_api/public/attachments/attachment_service_proxy.h View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
maniscalco
Pavel, would you please review this change?
5 years, 9 months ago (2015-03-02 19:46:14 UTC) #1
maniscalco
Hi Pavel, would you please review this change?
5 years, 9 months ago (2015-03-03 17:23:23 UTC) #3
pavely
lgtm
5 years, 9 months ago (2015-03-03 19:11:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/973513002/20001
5 years, 9 months ago (2015-03-03 23:40:58 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 00:47:30 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 00:48:51 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f9648891191bb34bce0a4c4d0110d82dc23b9ee6
Cr-Commit-Position: refs/heads/master@{#318981}

Powered by Google App Engine
This is Rietveld 408576698