Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: sync/internal_api/attachments/attachment_service_impl.cc

Issue 973513002: [Sync] Remove DropAttachments from AttachmentService and SyncData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix call count. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/api/sync_data_unittest.cc ('k') | sync/internal_api/attachments/attachment_service_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/attachments/attachment_service_impl.cc
diff --git a/sync/internal_api/attachments/attachment_service_impl.cc b/sync/internal_api/attachments/attachment_service_impl.cc
index dab7aa73f8f283150372e3c216cac02f8b074569..cc04408ef332c76f8afcb8b3e9ec11a8e7711ba9 100644
--- a/sync/internal_api/attachments/attachment_service_impl.cc
+++ b/sync/internal_api/attachments/attachment_service_impl.cc
@@ -176,16 +176,6 @@ void AttachmentServiceImpl::GetOrDownloadAttachments(
state));
}
-void AttachmentServiceImpl::DropAttachments(
- const AttachmentIdList& attachment_ids,
- const DropCallback& callback) {
- DCHECK(CalledOnValidThread());
- attachment_store_->Drop(attachment_ids,
- base::Bind(&AttachmentServiceImpl::DropDone,
- weak_ptr_factory_.GetWeakPtr(),
- callback));
-}
-
void AttachmentServiceImpl::ReadDone(
const scoped_refptr<GetOrDownloadState>& state,
const AttachmentStore::Result& result,
@@ -234,18 +224,6 @@ void AttachmentServiceImpl::WriteDone(
}
}
-void AttachmentServiceImpl::DropDone(const DropCallback& callback,
- const AttachmentStore::Result& result) {
- AttachmentService::DropResult drop_result =
- AttachmentService::DROP_UNSPECIFIED_ERROR;
- if (result == AttachmentStore::SUCCESS) {
- drop_result = AttachmentService::DROP_SUCCESS;
- }
- // TODO(maniscalco): Deal with case where an error occurred (bug 361251).
- base::MessageLoop::current()->PostTask(FROM_HERE,
- base::Bind(callback, drop_result));
-}
-
void AttachmentServiceImpl::UploadDone(
const AttachmentUploader::UploadResult& result,
const AttachmentId& attachment_id) {
« no previous file with comments | « sync/api/sync_data_unittest.cc ('k') | sync/internal_api/attachments/attachment_service_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698