Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: sync/internal_api/attachments/attachment_service_proxy_unittest.cc

Issue 973513002: [Sync] Remove DropAttachments from AttachmentService and SyncData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix call count. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/attachments/attachment_service_proxy_unittest.cc
diff --git a/sync/internal_api/attachments/attachment_service_proxy_unittest.cc b/sync/internal_api/attachments/attachment_service_proxy_unittest.cc
index 2353d263c4b3522eaab02130f7096868b9c3c445..41af1b233710914b1e42caf3cd25a96c9f6727b2 100644
--- a/sync/internal_api/attachments/attachment_service_proxy_unittest.cc
+++ b/sync/internal_api/attachments/attachment_service_proxy_unittest.cc
@@ -48,14 +48,6 @@ class StubAttachmentService : public AttachmentService,
base::Passed(&attachments)));
}
- void DropAttachments(const AttachmentIdList& attachment_ids,
- const DropCallback& callback) override {
- CalledOnValidThread();
- Increment();
- base::MessageLoop::current()->PostTask(
- FROM_HERE, base::Bind(callback, AttachmentService::DROP_SUCCESS));
- }
-
void UploadAttachments(const AttachmentIdSet& attachments_ids) override {
CalledOnValidThread();
Increment();
@@ -101,10 +93,7 @@ class AttachmentServiceProxyTest : public testing::Test,
callback_get_or_download =
base::Bind(&AttachmentServiceProxyTest::IncrementGetOrDownload,
base::Unretained(this));
- callback_drop = base::Bind(&AttachmentServiceProxyTest::IncrementDrop,
- base::Unretained(this));
count_callback_get_or_download = 0;
- count_callback_drop = 0;
}
void TearDown() override {
@@ -124,12 +113,6 @@ class AttachmentServiceProxyTest : public testing::Test,
++count_callback_get_or_download;
}
- // a DropCallback
- void IncrementDrop(const AttachmentService::DropResult&) {
- CalledOnValidThread();
- ++count_callback_drop;
- }
-
void WaitForStubThread() {
base::WaitableEvent done(false, false);
stub_thread->message_loop()->PostTask(
@@ -144,12 +127,9 @@ class AttachmentServiceProxyTest : public testing::Test,
scoped_ptr<AttachmentServiceProxy> proxy;
AttachmentService::GetOrDownloadCallback callback_get_or_download;
- AttachmentService::DropCallback callback_drop;
// number of times callback_get_or_download was invoked
int count_callback_get_or_download;
- // number of times callback_drop was invoked
- int count_callback_drop;
};
TEST_F(AttachmentServiceProxyTest, GetStore) {
@@ -161,11 +141,10 @@ TEST_F(AttachmentServiceProxyTest, GetStore) {
// thread.
TEST_F(AttachmentServiceProxyTest, MethodsAreProxied) {
proxy->GetOrDownloadAttachments(AttachmentIdList(), callback_get_or_download);
- proxy->DropAttachments(AttachmentIdList(), callback_drop);
proxy->UploadAttachments(AttachmentIdSet());
// Wait for the posted calls to execute in the stub thread.
WaitForStubThread();
- EXPECT_EQ(3, stub->GetCallCount());
+ EXPECT_EQ(2, stub->GetCallCount());
// At this point the stub thread has finished executed the calls. However, the
// result callbacks it has posted may not have executed yet. Wait a second
// time to ensure the stub thread has executed the posted result callbacks.
@@ -173,7 +152,6 @@ TEST_F(AttachmentServiceProxyTest, MethodsAreProxied) {
base::RunLoop().RunUntilIdle();
EXPECT_EQ(1, count_callback_get_or_download);
- EXPECT_EQ(1, count_callback_drop);
}
// Verify that it's safe to use an AttachmentServiceProxy even after its wrapped
« no previous file with comments | « sync/internal_api/attachments/attachment_service_proxy.cc ('k') | sync/internal_api/public/attachments/attachment_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698