Files.app: Mitigate performance issue on select-all by prefetching content mime type.

Files.app: Mitigate performance issue on select-all by prefetching content mime type.

BUG=458915
TEST=Select 2000 photos by Ctrl+A and check that UI responds in less than 500ms.

Committed: https://crrev.com/a8d56decc5033dbc58f4f1023e5c8293568a8723
Cr-Commit-Position: refs/heads/master@{#318853}

[fukino, 2015-03-02 15:20:49]

fukino@chromium.org changed reviewers:
+ hirono@chromium.org

[fukino, 2015-03-02 15:20:49]

Could you take a look? Thanks!

[hirono, 2015-03-03 01:49:44]

On 2015/03/02 15:20:49, fukino wrote:
> Could you take a look? Thanks!

If the contentMimeType property is used other than list container, could you
define constant for the class that uses contentMimeType (selection related
class?) and refer it in createPrefetchPropertyNames_?
https://code.google.com/p/chromium/codesearch#chromium/src/ui/file_manager/fi...

[fukino, 2015-03-03 06:36:40]

On 2015/03/03 01:49:44, hirono wrote:
> If the contentMimeType property is used other than list container, could you
> define constant for the class that uses contentMimeType (selection related
> class?) and refer it in createPrefetchPropertyNames_?
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/file_manager/fi...

Done.
Additionally, I removed Function.bind from iteration for all selected files.
Could you take a look at file_transfer_controller.js, too?
Thanks!

[hirono, 2015-03-03 06:50:01]

lgtm! Thanks!

https://codereview.chromium.org/973483002/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/file_selection.js (right):

https://codereview.chromium.org/973483002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_selection.js:108: * These
metadata is expected to be cached.
nit: Could you mention that the names are needed for optimization? (and maybe
bug number?) The code itself works without prefetching. So someone may try to
remove this in the future.

[fukino, 2015-03-03 07:23:44]

Thank you!

https://codereview.chromium.org/973483002/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/file_selection.js (right):

https://codereview.chromium.org/973483002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_selection.js:108: * These
metadata is expected to be cached.
On 2015/03/03 06:50:01, hirono wrote:
> nit: Could you mention that the names are needed for optimization? (and maybe
> bug number?) The code itself works without prefetching. So someone may try to
> remove this in the future.

Done.

[hirono, 2015-03-03 07:24:44]

On 2015/03/03 07:23:44, fukino wrote:
> Thank you!
> 
>
https://codereview.chromium.org/973483002/diff/20001/ui/file_manager/file_man...
> File ui/file_manager/file_manager/foreground/js/file_selection.js (right):
> 
>
https://codereview.chromium.org/973483002/diff/20001/ui/file_manager/file_man...
> ui/file_manager/file_manager/foreground/js/file_selection.js:108: * These
> metadata is expected to be cached.
> On 2015/03/03 06:50:01, hirono wrote:
> > nit: Could you mention that the names are needed for optimization? (and
maybe
> > bug number?) The code itself works without prefetching. So someone may try
to
> > remove this in the future.
> 
> Done.

still lgtm, thanks!

[fukino, 2015-03-03 07:24:57]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2015-03-03 07:25:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/973483002/40001

[commit-bot: I haz the power, 2015-03-03 08:04:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-03 08:05:44]

Patchset 3 (id:??) landed as
https://crrev.com/a8d56decc5033dbc58f4f1023e5c8293568a8723
Cr-Commit-Position: refs/heads/master@{#318853}