ui/file_manager/file_manager/foreground/js/directory_contents.js - Issue 973483002: Files.app: Mitigate performance issue on select-all by prefetching content mime type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/directory_contents.js

Issue 973483002: Files.app: Mitigate performance issue on select-all by prefetching content mime type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a comment about performance optimization, and attached a link to crbug. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/file_manager/file_manager/foreground/js/directory_contents.js

diff --git a/ui/file_manager/file_manager/foreground/js/directory_contents.js b/ui/file_manager/file_manager/foreground/js/directory_contents.js

index a0b2405f6e08df567bb0a9a0ba0eea002f47ac5c..8668e665597d759ddbd6650e6b8a4e74a4352528 100644

--- a/ui/file_manager/file_manager/foreground/js/directory_contents.js

+++ b/ui/file_manager/file_manager/foreground/js/directory_contents.js

@@ -580,6 +580,11 @@ FileListContext.createPrefetchPropertyNames_ = function() {

for (var i = 0; i < Command.METADATA_PREFETCH_PROPERTY_NAMES.length; i++) {

set[Command.METADATA_PREFETCH_PROPERTY_NAMES[i]] = true;

}

+ for (var i = 0;

+ i < FileSelection.METADATA_PREFETCH_PROPERTY_NAMES.length;

+ i++) {

+ set[FileSelection.METADATA_PREFETCH_PROPERTY_NAMES[i]] = true;

+ }

return Object.keys(set);

};

« no previous file with comments | « no previous file | ui/file_manager/file_manager/foreground/js/file_selection.js » ('j') | no next file with comments »