ui/file_manager/file_manager/foreground/js/file_selection.js - Issue 973483002: Files.app: Mitigate performance issue on select-all by prefetching content mime type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/file_selection.js

Issue 973483002: Files.app: Mitigate performance issue on select-all by prefetching content mime type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a comment about performance optimization, and attached a link to crbug. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/directory_contents.js ('k') | ui/file_manager/file_manager/foreground/js/file_transfer_controller.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/file_selection.js

diff --git a/ui/file_manager/file_manager/foreground/js/file_selection.js b/ui/file_manager/file_manager/foreground/js/file_selection.js

index 3d2f85264a6aa2daa4b9b1e913b94b7021908290..fc47d1750bc6f8ba37be98d603c6256a9473c930 100644

--- a/ui/file_manager/file_manager/foreground/js/file_selection.js

+++ b/ui/file_manager/file_manager/foreground/js/file_selection.js

@@ -104,6 +104,17 @@ function FileSelection(fileManager, indexes) {

}

/**

+ * Metadata property names used by FileSelection.

+ * These metadata is expected to be cached to accelerate completeInit() of

+ * FileSelection. crbug.com/458915.

+ * @const {!Array<string>}

+ */

+FileSelection.METADATA_PREFETCH_PROPERTY_NAMES = [

+ 'availableOffline',

+ 'contentMimeType',

+];

+/**

* Computes data required to get file tasks and requests the tasks.

* @return {!Promise}