Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 9732010: Check that attachments are the correct type for the attachment type (Closed)

Created:
8 years, 9 months ago by greggman
Modified:
8 years, 9 months ago
Reviewers:
jbauman
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Check that attachments are the correct type for the attachment type TEST=unit tests BUG=102232 R=jbauman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -17 lines) Patch
M gpu/command_buffer/common/gles2_cmd_utils.h View 2 chunks +18 lines, -5 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 chunk +33 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.cc View 2 chunks +13 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager_unittest.cc View 6 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
greggman
Hey John, PTAL
8 years, 9 months ago (2012-03-19 20:42:07 UTC) #1
jbauman
lgtm
8 years, 9 months ago (2012-03-19 21:03:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/9732010/1
8 years, 9 months ago (2012-03-19 21:05:05 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-19 22:48:39 UTC) #4
Change committed as 127559

Powered by Google App Engine
This is Rietveld 408576698