Check that attachments are the correct type for the attachment type

gpu/command_buffer/service/framebuffer_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/framebuffer_manager.h"
 #include "base/logging.h"
 #include "gpu/command_buffer/common/gles2_cmd_utils.h"
 
 namespace gpu {
 namespace gles2 {
@@ skipping 45 matching lines @@
 
   virtual bool CanRenderTo() const {
     return true;
   }
 
   virtual void DetachFromFramebuffer() {
     // Nothing to do for renderbuffers.
   }
 
   virtual bool ValidForAttachmentType(GLenum attachment_type) {
-    // TODO(gman): Fill this out.
-    return true;
+    uint32 need = GLES2Util::GetChannelsNeededForAttachmentType(
+        attachment_type);
+    uint32 have = GLES2Util::GetChannelsForFormat(internal_format());
+    return (need & have) != 0;
   }
 
   RenderbufferManager::RenderbufferInfo* renderbuffer() const {
     return renderbuffer_.get();
   }
 
  private:
   RenderbufferManager::RenderbufferInfo::Ref renderbuffer_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderbufferAttachment);
@@ skipping 61 matching lines @@
 
   virtual bool CanRenderTo() const {
     return texture_->CanRenderTo();
   }
 
   virtual void DetachFromFramebuffer() {
     texture_->DetachFromFramebuffer();
   }
 
   virtual bool ValidForAttachmentType(GLenum attachment_type) {
-    // TODO(gman): Fill this out.
-    return true;
+    GLenum type = 0;
+    GLenum internal_format = 0;
+    if (!texture_->GetLevelType(target_, level_, &type, &internal_format)) {
+      return false;
+    }
+    uint32 need = GLES2Util::GetChannelsNeededForAttachmentType(
+        attachment_type);
+    uint32 have = GLES2Util::GetChannelsForFormat(internal_format);
+    return (need & have) != 0;
   }
 
  private:
   TextureManager::TextureInfo::Ref texture_;
   GLenum target_;
   GLint level_;
 
   DISALLOW_COPY_AND_ASSIGN(TextureAttachment);
 };
 
@@ skipping 266 matching lines @@
     FramebufferManager::FramebufferInfo* framebuffer) {
   DCHECK(framebuffer);
   return framebuffer->framebuffer_complete_state_count_id() ==
       framebuffer_state_change_count_;
 }
 
 }  // namespace gles2
 }  // namespace gpu