Check that attachments are the correct type for the attachment type

gpu/command_buffer/service/framebuffer_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/framebuffer_manager.h"
 #include "gpu/command_buffer/service/feature_info.h"
 
 #include "gpu/command_buffer/common/gl_mock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 158 matching lines @@
   const GLuint kRenderbufferService1Id = 333;
   const GLuint kRenderbufferClient2Id = 34;
   const GLuint kRenderbufferService2Id = 334;
   const GLuint kRenderbufferClient3Id = 35;
   const GLuint kRenderbufferService3Id = 335;
   const GLuint kRenderbufferClient4Id = 36;
   const GLuint kRenderbufferService4Id = 336;
   const GLsizei kWidth1 = 16;
   const GLsizei kHeight1 = 32;
   const GLenum kFormat1 = GL_RGBA4;
+  const GLenum kBadFormat1 = GL_DEPTH_COMPONENT16;
   const GLsizei kSamples1 = 0;
   const GLsizei kWidth2 = 16;
   const GLsizei kHeight2 = 32;
   const GLenum kFormat2 = GL_DEPTH_COMPONENT16;
   const GLsizei kSamples2 = 0;
   const GLsizei kWidth3 = 16;
   const GLsizei kHeight3 = 32;
   const GLenum kFormat3 = GL_STENCIL_INDEX8;
   const GLsizei kSamples3 = 0;
   const GLsizei kWidth4 = 16;
@@ skipping 16 matching lines @@
   info_->AttachRenderbuffer(GL_COLOR_ATTACHMENT0, rb_info1);
   EXPECT_FALSE(info_->HasUnclearedAttachment(GL_COLOR_ATTACHMENT0));
   EXPECT_FALSE(info_->HasUnclearedAttachment(GL_DEPTH_ATTACHMENT));
   EXPECT_EQ(static_cast<GLenum>(GL_RGBA4), info_->GetColorAttachmentFormat());
   EXPECT_FALSE(info_->HasDepthAttachment());
   EXPECT_FALSE(info_->HasStencilAttachment());
   EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT),
             info_->IsPossiblyComplete());
   EXPECT_TRUE(info_->IsCleared());
 
+  // Try a format that's not good for COLOR_ATTACHMENT0.
+  renderbuffer_manager_.SetInfo(
+      rb_info1, kSamples1, kBadFormat1, kWidth1, kHeight1);
+  EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT),
+            info_->IsPossiblyComplete());
+
+  // Try a good format.
   renderbuffer_manager_.SetInfo(
       rb_info1, kSamples1, kFormat1, kWidth1, kHeight1);
   EXPECT_EQ(static_cast<GLenum>(kFormat1), info_->GetColorAttachmentFormat());
   EXPECT_FALSE(info_->HasDepthAttachment());
   EXPECT_FALSE(info_->HasStencilAttachment());
   EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_COMPLETE),
             info_->IsPossiblyComplete());
   EXPECT_FALSE(info_->IsCleared());
 
   // check adding another
@@ skipping 37 matching lines @@
   // Check adding one that is already cleared.
   renderbuffer_manager_.CreateRenderbufferInfo(
       kRenderbufferClient3Id, kRenderbufferService3Id);
   RenderbufferManager::RenderbufferInfo* rb_info3 =
       renderbuffer_manager_.GetRenderbufferInfo(kRenderbufferClient3Id);
   ASSERT_TRUE(rb_info3 != NULL);
   renderbuffer_manager_.SetInfo(
       rb_info3, kSamples3, kFormat3, kWidth3, kHeight3);
   renderbuffer_manager_.SetCleared(rb_info3);
 
-  info_->AttachRenderbuffer(GL_STENCIL_ATTACHMENT, rb_info1);
+  info_->AttachRenderbuffer(GL_STENCIL_ATTACHMENT, rb_info3);
   EXPECT_FALSE(info_->HasUnclearedAttachment(GL_STENCIL_ATTACHMENT));
   EXPECT_EQ(static_cast<GLenum>(kFormat1), info_->GetColorAttachmentFormat());
   EXPECT_TRUE(info_->HasDepthAttachment());
   EXPECT_TRUE(info_->HasStencilAttachment());
   EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_COMPLETE),
             info_->IsPossiblyComplete());
   EXPECT_TRUE(info_->IsCleared());
 
   // Check marking the renderbuffer as unclared.
   renderbuffer_manager_.SetInfo(
       rb_info1, kSamples1, kFormat1, kWidth1, kHeight1);
   EXPECT_EQ(static_cast<GLenum>(kFormat1), info_->GetColorAttachmentFormat());
   EXPECT_TRUE(info_->HasDepthAttachment());
   EXPECT_TRUE(info_->HasStencilAttachment());
   EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_COMPLETE),
             info_->IsPossiblyComplete());
   EXPECT_FALSE(info_->IsCleared());
 
   const FramebufferManager::FramebufferInfo::Attachment* attachment =
       info_->GetAttachment(GL_COLOR_ATTACHMENT0);
   ASSERT_TRUE(attachment != NULL);
   EXPECT_EQ(kWidth1, attachment->width());
   EXPECT_EQ(kHeight1, attachment->height());
   EXPECT_EQ(kSamples1, attachment->samples());
   EXPECT_EQ(kFormat1, attachment->internal_format());
   EXPECT_FALSE(attachment->cleared());
 
-  EXPECT_TRUE(info_->HasUnclearedAttachment(GL_STENCIL_ATTACHMENT));
+  EXPECT_TRUE(info_->HasUnclearedAttachment(GL_COLOR_ATTACHMENT0));
 
   // Clear it.
   manager_.MarkAttachmentsAsCleared(
       info_, &renderbuffer_manager_, &texture_manager_);
-  EXPECT_FALSE(info_->HasUnclearedAttachment(GL_STENCIL_ATTACHMENT));
+  EXPECT_FALSE(info_->HasUnclearedAttachment(GL_COLOR_ATTACHMENT0));
   EXPECT_TRUE(info_->IsCleared());
 
   // Check replacing an attachment
   renderbuffer_manager_.CreateRenderbufferInfo(
       kRenderbufferClient4Id, kRenderbufferService4Id);
   RenderbufferManager::RenderbufferInfo* rb_info4 =
       renderbuffer_manager_.GetRenderbufferInfo(kRenderbufferClient4Id);
   ASSERT_TRUE(rb_info4 != NULL);
   renderbuffer_manager_.SetInfo(
       rb_info4, kSamples4, kFormat4, kWidth4, kHeight4);
@@ skipping 55 matching lines @@
   const GLuint kTextureService1Id = 333;
   const GLuint kTextureClient2Id = 34;
   const GLuint kTextureService2Id = 334;
   const GLint kDepth = 1;
   const GLint kBorder = 0;
   const GLenum kType = GL_UNSIGNED_BYTE;
   const GLsizei kWidth1 = 16;
   const GLsizei kHeight1 = 32;
   const GLint kLevel1 = 0;
   const GLenum kFormat1 = GL_RGBA;
+  const GLenum kBadFormat1 = GL_DEPTH_COMPONENT16;
   const GLenum kTarget1 = GL_TEXTURE_2D;
   const GLsizei kSamples1 = 0;
   const GLsizei kWidth2 = 16;
   const GLsizei kHeight2 = 32;
   const GLint kLevel2 = 0;
   const GLenum kFormat2 = GL_RGB;
   const GLenum kTarget2 = GL_TEXTURE_2D;
   const GLsizei kSamples2 = 0;
   const GLsizei kWidth3 = 75;
   const GLsizei kHeight3 = 123;
@@ skipping 13 matching lines @@
   ASSERT_TRUE(tex_info1 != NULL);
 
   // check adding one attachment
   info_->AttachTexture(GL_COLOR_ATTACHMENT0, tex_info1, kTarget1, kLevel1);
   EXPECT_FALSE(info_->HasUnclearedAttachment(GL_COLOR_ATTACHMENT0));
   EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT),
             info_->IsPossiblyComplete());
   EXPECT_TRUE(info_->IsCleared());
   EXPECT_EQ(static_cast<GLenum>(0), info_->GetColorAttachmentFormat());
 
+  // Try format that doesn't work with COLOR_ATTACHMENT0
   texture_manager_.SetInfoTarget(tex_info1, GL_TEXTURE_2D);
   texture_manager_.SetLevelInfo(
       tex_info1, GL_TEXTURE_2D, kLevel1,
+      kBadFormat1, kWidth1, kHeight1, kDepth, kBorder, kBadFormat1, kType,
+      true);
+  EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT),
+            info_->IsPossiblyComplete());
+
+  // Try a good format.
+  texture_manager_.SetLevelInfo(
+      tex_info1, GL_TEXTURE_2D, kLevel1,
       kFormat1, kWidth1, kHeight1, kDepth, kBorder, kFormat1, kType, false);
   EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_COMPLETE),
             info_->IsPossiblyComplete());
   EXPECT_FALSE(info_->IsCleared());
   texture_manager_.SetLevelInfo(
       tex_info1, GL_TEXTURE_2D, kLevel1,
       kFormat1, kWidth1, kHeight1, kDepth, kBorder, kFormat1, kType, true);
   EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_COMPLETE),
             info_->IsPossiblyComplete());
   EXPECT_TRUE(info_->IsCleared());
@@ skipping 176 matching lines @@
   manager_.MarkAsComplete(info_);
   EXPECT_TRUE(manager_.IsComplete(info_));
   info_->UnbindTexture(kTarget1, tex_info2);
   EXPECT_FALSE(manager_.IsComplete(info_));
 }
 
 }  // namespace gles2
 }  // namespace gpu