Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 972713002: gpu/blink: Cleanup - Remove 'using' declarations from webgraphicscontext3d_impl.h. (Closed)

Created:
5 years, 9 months ago by tfarina
Modified:
5 years, 9 months ago
Reviewers:
no sievers, piman
CC:
chromium-reviews, piman+watch_chromium.org, jamesr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu/blink: Cleanup - Remove 'using' declarations from webgraphicscontext3d_impl.h. Having 'using' declarations in header files polutes the global namespace and that is not what we want. BUG=438860 R=piman@chromium.org Committed: https://crrev.com/4049b3a9c901c57a0be051c998bae9ff7509b04c Cr-Commit-Position: refs/heads/master@{#319766}

Patch Set 1 #

Patch Set 2 : ... #

Patch Set 3 : content_shell LINKs #

Patch Set 4 : WGC3Denum #

Patch Set 5 : WGC3Dbyte #

Patch Set 6 : WGC3Dsizei #

Patch Set 7 : WGC3Dchar #

Patch Set 8 : WGC3Dint #

Patch Set 9 : WGC3Duint #

Total comments: 4

Patch Set 10 : review + REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+823 lines, -613 lines) Patch
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_impl.h View 1 2 3 4 5 6 7 8 9 6 chunks +803 lines, -611 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_impl.cc View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
tfarina
Oh man! This was tedious! It was all formatted by clang-format with 'g cl format'. ...
5 years, 9 months ago (2015-03-06 23:59:40 UTC) #1
tfarina
Daniel, could you approve this to me? Thanks!
5 years, 9 months ago (2015-03-09 21:50:55 UTC) #3
no sievers
lgtm https://codereview.chromium.org/972713002/diff/150001/gpu/blink/webgraphicscontext3d_impl.h File gpu/blink/webgraphicscontext3d_impl.h (right): https://codereview.chromium.org/972713002/diff/150001/gpu/blink/webgraphicscontext3d_impl.h#newcode692 gpu/blink/webgraphicscontext3d_impl.h:692: // blink::blink::WGC3Duint64 timeout); nit: just one blink:: https://codereview.chromium.org/972713002/diff/150001/gpu/blink/webgraphicscontext3d_impl.h#newcode912 ...
5 years, 9 months ago (2015-03-09 21:57:13 UTC) #4
tfarina
https://codereview.chromium.org/972713002/diff/150001/gpu/blink/webgraphicscontext3d_impl.h File gpu/blink/webgraphicscontext3d_impl.h (right): https://codereview.chromium.org/972713002/diff/150001/gpu/blink/webgraphicscontext3d_impl.h#newcode692 gpu/blink/webgraphicscontext3d_impl.h:692: // blink::blink::WGC3Duint64 timeout); On 2015/03/09 21:57:13, sievers wrote: > ...
5 years, 9 months ago (2015-03-09 22:03:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972713002/170001
5 years, 9 months ago (2015-03-09 22:04:37 UTC) #8
commit-bot: I haz the power
Committed patchset #10 (id:170001)
5 years, 9 months ago (2015-03-09 23:28:03 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 23:28:57 UTC) #10
Message was sent while issue was closed. 
Patchset 10 (id:??) landed as
https://crrev.com/4049b3a9c901c57a0be051c998bae9ff7509b04c
Cr-Commit-Position: refs/heads/master@{#319766}

Powered by Google App Engine
This is Rietveld 408576698