Refactor codes to run only the bitmap converting logic in background

Refactor codes to run only the bitmap converting logic in background

This is to fix regression of https://codereview.chromium.org/913033002.

BUG=455996
Committed: https://crrev.com/fb9b01d202733f2ab696c3718fc32fee17d91cf5
Cr-Commit-Position: refs/heads/master@{#319010}

[Jaekyun Seok (inactive), 2015-03-03 23:49:08]

jaekyun@chromium.org changed reviewers:
+ aurimas@chromium.org, changwan@chromium.org, tedchoc@chromium.org

[Jaekyun Seok (inactive), 2015-03-03 23:49:09]

Please review this CL.

[Ted C, 2015-03-04 00:09:57]

https://codereview.chromium.org/972293003/diff/1/chrome/android/java/src/org/...
File chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
(right):

https://codereview.chromium.org/972293003/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:249:
intent.putExtra(EXTRA_RAW_FILE_PATH, saveFile.getAbsolutePath());
Hmm...I don't really like that we have to muck with the intent after getting
this to make it work.

Maybe we can see about only doing the conversion from the bitmap to a file in
the background thread and rework some signatures to make that work?

Then you could change it to take a screenshotFile in this method signature and
add the extra if it's not null.

[Jaekyun Seok (inactive), 2015-03-04 00:39:13]

PTAL.

https://codereview.chromium.org/972293003/diff/1/chrome/android/java/src/org/...
File chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
(right):

https://codereview.chromium.org/972293003/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:249:
intent.putExtra(EXTRA_RAW_FILE_PATH, saveFile.getAbsolutePath());
On 2015/03/04 00:09:57, Ted C wrote:
> Hmm...I don't really like that we have to muck with the intent after getting
> this to make it work.
> 
> Maybe we can see about only doing the conversion from the bitmap to a file in
> the background thread and rework some signatures to make that work?
> 
> Then you could change it to take a screenshotFile in this method signature and
> add the extra if it's not null.

Done.

[Ted C, 2015-03-04 00:43:35]

lgtm

https://codereview.chromium.org/972293003/diff/20001/chrome/android/java/src/...
File chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
(right):

https://codereview.chromium.org/972293003/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:52:
private static final String EXTRA_RAW_FILE_PATH = "raw-file-path";
unused?

[Jaekyun Seok (inactive), 2015-03-04 00:48:14]

https://codereview.chromium.org/972293003/diff/20001/chrome/android/java/src/...
File chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
(right):

https://codereview.chromium.org/972293003/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:52:
private static final String EXTRA_RAW_FILE_PATH = "raw-file-path";
On 2015/03/04 00:43:35, Ted C wrote:
> unused?

Done.

[Jaekyun Seok (inactive), 2015-03-04 00:48:20]

The CQ bit was checked by jaekyun@chromium.org

[Jaekyun Seok (inactive), 2015-03-04 00:48:21]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/972293003/#ps40001 (title:
"Remove unused constant")

[commit-bot: I haz the power, 2015-03-04 00:49:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/972293003/40001

[commit-bot: I haz the power, 2015-03-04 02:50:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-04 02:50:24]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
Timed out jobs are not retried to avoid causing additional load on the builders
with large pending queues.

[Jaekyun Seok (inactive), 2015-03-04 02:50:39]

The CQ bit was checked by jaekyun@chromium.org

[commit-bot: I haz the power, 2015-03-04 02:50:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/972293003/40001

[commit-bot: I haz the power, 2015-03-04 02:55:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-04 02:56:31]

Patchset 3 (id:??) landed as
https://crrev.com/fb9b01d202733f2ab696c3718fc32fee17d91cf5
Cr-Commit-Position: refs/heads/master@{#319010}