Refactor codes to run only the bitmap converting logic in background

chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.share;
 
 import android.app.Activity;
 import android.app.AlertDialog;
 import android.content.ComponentName;
 import android.content.Context;
@@ skipping 30 matching lines @@
 
 /**
  * A helper class that helps to start an intent to share titles and URLs.
  */
 public class ShareHelper {
 
     private static final String TAG = "ShareHelper";
 
     private static final String PACKAGE_NAME_KEY = "last_shared_package_name";
     private static final String CLASS_NAME_KEY = "last_shared_class_name";
+    private static final String EXTRA_RAW_FILE_PATH = "raw-file-path";
 
     /**
      * Directory name for screenshots.
      */
     private static final String SCREENSHOT_DIRECTORY_NAME = "screenshot";
 
     private ShareHelper() {}
 
     private static void deleteScreenshotFiles(File file) {
         if (!file.exists()) return;
@@ skipping 112 matching lines @@
                 @Override
                 protected Intent doInBackground(Void... params) {
                     return getDirectShareIntentForComponent(
                             activity, title, url, screenshot, component);
                 }
 
                 @Override
                 protected void onPostExecute(Intent intent) {
                     if (ApplicationStatus.getStateForApplication()
                             != ApplicationState.HAS_DESTROYED_ACTIVITIES) {
+                        String rawFilePath = intent.getStringExtra(EXTRA_RAW_FILE_PATH);
+                        if (rawFilePath != null) {
+                            intent.putExtra(Intent.EXTRA_STREAM, UiUtils.getUriForImageCaptureFile(
+                                    activity, new File(rawFilePath)));
+                            intent.removeExtra(EXTRA_RAW_FILE_PATH);
+                        }
                         activity.startActivity(intent);
                     }
                 }
             }.execute();
         }
     }
 
     /**
      * Set the icon and the title for the menu item used for direct share.
      *
@@ skipping 39 matching lines @@
                         UiUtils.getDirectoryForImageCapture(context), SCREENSHOT_DIRECTORY_NAME);
                 if (path.exists() || path.mkdir()) {
                     File saveFile = File.createTempFile(
                             String.valueOf(System.currentTimeMillis()), ".jpg", path);
                     fOut = new FileOutputStream(saveFile);
                     screenshot.compress(Bitmap.CompressFormat.JPEG, 85, fOut);
                     fOut.flush();
                     fOut.close();
 
                     intent.addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION);
-                    intent.putExtra(Intent.EXTRA_STREAM,
-                            UiUtils.getUriForImageCaptureFile(context, saveFile));
+                    intent.putExtra(EXTRA_RAW_FILE_PATH, saveFile.getAbsolutePath());

[Ted C, 2015/03/04 00:09:57]

Hmm...I don't really like that we have to muck with the intent after getting
this to make it work.

Maybe we can see about only doing the conversion from the bitmap to a file in
the background thread and rework some signatures to make that work?

Then you could change it to take a screenshotFile in this method signature and
add the extra if it's not null.

[Jaekyun Seok (inactive), 2015/03/04 00:39:13]

Done.

                 }
             } catch (IOException ie) {
                 if (fOut != null) {
                     try {
                         fOut.close();
                     } catch (IOException e) {
                         // Ignore exception.
                     }
                 }
             }
@@ skipping 19 matching lines @@
     }
 
     private static void setLastShareComponentName(Context context, ComponentName component) {
         SharedPreferences preferences = PreferenceManager.getDefaultSharedPreferences(context);
         SharedPreferences.Editor editor = preferences.edit();
         editor.putString(PACKAGE_NAME_KEY, component.getPackageName());
         editor.putString(CLASS_NAME_KEY, component.getClassName());
         editor.apply();
     }
 }