Removes dartc reliance on its own libraries, now can be targeted at any implementation's libraries

Removes dartc reliance on its own libraries, now can be targeted at any implementation's libraries

Adds a new cmdline flag

--dart-sdk to point it at a directory where the dart library files are staged
--implementation-name the name of the implemenation {dartium, vm, frog, leg} 
  to target with the analyzer

Support for reading headers from a .jar file is removed.
The configuration was changed to output the scripts into a 
directory named 'analysis' instead of 'compiler'.  

The name of the script to invoked is now 'darta' (for Dart 
analyzer) instead of dartc to free that name up for the 
Dart -> JS compiler.

[ahe, 2012-03-20 21:34:09]

I guess you haven't made this ready for review yet, so some of my comments are
probably irrelevant.

https://chromiumcodereview.appspot.com/9702034/diff/1/compiler/dart-compiler.gyp
File compiler/dart-compiler.gyp (right):

https://chromiumcodereview.appspot.com/9702034/diff/1/compiler/dart-compiler....
compiler/dart-compiler.gyp:30: '../third_party/json/r2_20080312/json.jar',
Do you still need json?

https://chromiumcodereview.appspot.com/9702034/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/DartCompiler.java (right):

https://chromiumcodereview.appspot.com/9702034/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/DartCompiler.java:155:
usePrecompiledDartLibs = false;
I don't think anyone is using this feature anymore.

https://chromiumcodereview.appspot.com/9702034/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/DartCompilerMainContext.java
(right):

https://chromiumcodereview.appspot.com/9702034/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/DartCompilerMainContext.java:151:
DartParser parser = DartParser.getSourceParser(libSrc, listener);
Remove tabs.

https://chromiumcodereview.appspot.com/9702034/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/DartCompilerMainContext.java:155:
throw(new RuntimeException(e));
Debug code?

https://chromiumcodereview.appspot.com/9702034/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/SystemLibraryManager.java (right):

https://chromiumcodereview.appspot.com/9702034/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:44: new
SystemLibraryPath("core", "core/core_frog.dart"),
Leg doesn't use the same libraries as Frog. You can find the Leg libraries here
in the repo: dart/frog/leg/lib/.

The code we use to translate dart URIs is in this file:
dart/frog/leg/apiimpl.dart

https://chromiumcodereview.appspot.com/9702034/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:97: } else if
(implementationName.equals("leg")) {
Would you mind renaming this to dart2js?

https://chromiumcodereview.appspot.com/9702034/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:102: throw new
RuntimeException("Invalid implentation name '" + implementationName + "',
expected one of vm, frog, leg, dartium");
Ditto.

https://chromiumcodereview.appspot.com/9702034/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:121: return
URI.create("file://" + uri.getPath());
Indentation.

https://chromiumcodereview.appspot.com/9702034/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:208: File lib =
new File(String.format("%s/%s", sdkLibPath, path.dartSourceFile));
Probably better to write:

new File(sdkLibPath, path.dartSourceFile)

[zundel, 2012-03-25 16:39:02]

This is a snapshot of my CL before trying to integrate with the editor.

I am afraid I might have made a mess of the dart URI semantics in here.  Things
work for the static analyzer because I got rid of dart://core/foo.dart semantics
which I guess are to be able to reference a specific file within a library.

http://codereview.chromium.org/9702034/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/DartCompiler.java (right):

http://codereview.chromium.org/9702034/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/DartCompiler.java:155:
usePrecompiledDartLibs = false;
On 2012/03/20 21:34:09, ahe wrote:
> I don't think anyone is using this feature anymore.

Done.

http://codereview.chromium.org/9702034/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/DartCompilerMainContext.java
(right):

http://codereview.chromium.org/9702034/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/DartCompilerMainContext.java:151:
DartParser parser = DartParser.getSourceParser(libSrc, listener);
On 2012/03/20 21:34:09, ahe wrote:
> Remove tabs.

Done.

http://codereview.chromium.org/9702034/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/DartCompilerMainContext.java:155:
throw(new RuntimeException(e));
On 2012/03/20 21:34:09, ahe wrote:
> Debug code?

reverted

http://codereview.chromium.org/9702034/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/SystemLibraryManager.java (right):

http://codereview.chromium.org/9702034/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:44: new
SystemLibraryPath("core", "core/core_frog.dart"),
On 2012/03/20 21:34:09, ahe wrote:
> Leg doesn't use the same libraries as Frog. You can find the Leg libraries
here
> in the repo: dart/frog/leg/lib/.
> 
> The code we use to translate dart URIs is in this file:
> dart/frog/leg/apiimpl.dart

We wukk need to update create_sdk.py to copy the leg libraries into dart-sdk for
this scheme to work.  All of the relative paths used in #source directives in
core.dart will have to be re-written to work in that directory structure.  dartc
needs to work in an environment outside of our svn repo layout.

Also, I would like to find a way so that this tool can discover the appropriate
libraries in the dart-sdk dir and not hard code them like this.  When this tool
is out of date with the implementation, users get a really poor development
experience.  I am sure that in the future we will have different revs of the SDK
and someone may want to develop against different revs without changing the
editor version.

http://codereview.chromium.org/9702034/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:97: } else if
(implementationName.equals("leg")) {
On 2012/03/20 21:34:09, ahe wrote:
> Would you mind renaming this to dart2js?

Done.

http://codereview.chromium.org/9702034/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:102: throw new
RuntimeException("Invalid implentation name '" + implementationName + "',
expected one of vm, frog, leg, dartium");
On 2012/03/20 21:34:09, ahe wrote:
> Ditto.

Done.

http://codereview.chromium.org/9702034/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:121: return
URI.create("file://" + uri.getPath());
On 2012/03/20 21:34:09, ahe wrote:
> Indentation.

Done.

http://codereview.chromium.org/9702034/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/SystemLibraryManager.java:208: File lib =
new File(String.format("%s/%s", sdkLibPath, path.dartSourceFile));
On 2012/03/20 21:34:09, ahe wrote:
> Probably better to write:
> 
> new File(sdkLibPath, path.dartSourceFile)

Done.

[zundel, 2012-03-26 22:22:36]

Patch Overflow Error: I will resubmit this as a series of smaller patches.