compiler/java/com/google/dart/compiler/resolver/Resolver.java - Issue 9702034: Removes dartc reliance on its own libraries, now can be targeted at any implementation's libraries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/Resolver.java

Issue 9702034: Removes dartc reliance on its own libraries, now can be targeted at any implementation's libraries (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: junit tests fixed Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java ('k') | compiler/java/com/google/dart/compiler/testing/TestCompilerConfiguration.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/Resolver.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/Resolver.java b/compiler/java/com/google/dart/compiler/resolver/Resolver.java

index 005fba3f4cb2176e2724384840d7c4ce58a91505..3623f3c172e933e91b438cf85e473eeed0f8d6aa 100644

--- a/compiler/java/com/google/dart/compiler/resolver/Resolver.java

+++ b/compiler/java/com/google/dart/compiler/resolver/Resolver.java

@@ -39,6 +39,7 @@ import com.google.dart.compiler.ast.DartMapLiteral;

import com.google.dart.compiler.ast.DartMethodDefinition;

import com.google.dart.compiler.ast.DartMethodInvocation;

import com.google.dart.compiler.ast.DartNamedExpression;

+import com.google.dart.compiler.ast.DartNativeBlock;

import com.google.dart.compiler.ast.DartNewExpression;

import com.google.dart.compiler.ast.DartNode;

import com.google.dart.compiler.ast.DartParameter;

@@ -595,7 +596,8 @@ public class Resolver {

}

- if ((functionNode.getBody() == null)

+ DartBlock body = functionNode.getBody();

+ if (body == null

&& !Elements.isNonFactoryConstructor(member)

&& !member.getModifiers().isAbstract()

&& !((ClassElement) member.getEnclosingElement()).isInterface()) {

@@ -603,7 +605,8 @@ public class Resolver {

}

resolve(functionNode.getBody());

- if (Elements.isNonFactoryConstructor(member)) {

+ if (Elements.isNonFactoryConstructor(member)

+ && !(body instanceof DartNativeBlock)) {

resolveInitializers(node, initializedFields);

// Test for missing final initialized fields

if (!this.currentHolder.isInterface() && !member.getModifiers().isRedirectedConstructor()) {