Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: compiler/lib/implementation/bool.dart

Issue 9702034: Removes dartc reliance on its own libraries, now can be targeted at any implementation's libraries (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: junit tests fixed Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « compiler/lib/implementation/arrays.dart ('k') | compiler/lib/implementation/bool.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/lib/implementation/bool.dart
diff --git a/compiler/lib/implementation/bool.dart b/compiler/lib/implementation/bool.dart
deleted file mode 100644
index 934fb6bfb55fd14c968e1163a8cf48dcf9a54489..0000000000000000000000000000000000000000
--- a/compiler/lib/implementation/bool.dart
+++ /dev/null
@@ -1,23 +0,0 @@
-// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-// Adds Dart-methods to the prototype of the JS Boolean function.
-// TODO(floitsch): the following comment needs to be updated once we compile
-// boolean checks with '=== true'.
-// WARNING: 'this' inside this class is always treated as 'true'.
-// That is if (this) ... will always pick the 'then' branch.
-// The reason is that, once compiled to JS, 'this' is represented by a
-// JS Boolean object. However "if (new Boolean(false)) .." picks the then
-// branch.
-class BoolImplementation implements bool native "Boolean" {
- bool operator ==(other) native;
-
- // TODO(floitsch): we should intercept toString for primitives, to avoid
- // creating a wrapper object.
- String toString() native;
-
- BoolImplementation toBool() native;
-
- get dynamic() { return toBool(); }
-}
« no previous file with comments | « compiler/lib/implementation/arrays.dart ('k') | compiler/lib/implementation/bool.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698