Issue 969893002: Make removing a transform not crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 969893002: Make removing a transform not crash. (Closed)

Created:
5 years, 9 months ago by ojan

Modified:
5 years, 9 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make removing a transform not crash. This broke with https://codereview.chromium.org/965013003. Before that patch, updateTransform was only called on the RenderLayer itself. Now it's called on the RenderBox, so we need to null check the RenderLayer. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/317cbae417fd48577cac332332f73aa27d784c47

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -4 lines)			Patch
M	sky/engine/core/rendering/RenderBox.cpp	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	sky/tests/styles/transforms.sky	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	sky/tests/styles/transforms-expected.txt	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 3 (1 generated)

ojan

5 years, 9 months ago (2015-03-02 22:37:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
317cbae417fd48577cac332332f73aa27d784c47 (presubmit successful).