Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: sky/tests/styles/transforms.sky

Issue 969893002: Make removing a transform not crash. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderBox.cpp ('k') | sky/tests/styles/transforms-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tests/styles/transforms.sky
diff --git a/sky/tests/styles/transforms.sky b/sky/tests/styles/transforms.sky
index 9473c915ea7cb736a745ce702bf0b2d7bde03e90..49c44de47618fbf3913127e9aabb524431d52cfc 100644
--- a/sky/tests/styles/transforms.sky
+++ b/sky/tests/styles/transforms.sky
@@ -48,5 +48,12 @@
test('scale should roundtrip', () {
testTransformRoundTrip('scale(1.2, 0.8)', 'matrix(1.2, 0, 0, 0.8, 0, 0)');
});
+
+ test('removing a transform should not crash', () {
+ testBox.style['transform'] = 'translate(0, 0, 0)';
+ testBox.getBoundingClientRect();
+ testBox.style.removeProperty('transform');
+ testBox.getBoundingClientRect();
+ });
}
</script>
« no previous file with comments | « sky/engine/core/rendering/RenderBox.cpp ('k') | sky/tests/styles/transforms-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698