Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 965013003: Move transforms from RenderLayer to RenderBox. (Closed)

Created:
5 years, 9 months ago by ojan
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move transforms from RenderLayer to RenderBox. This is more member data on RenderLayer that is now only used by RenderBox. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6a0dc6aa73140057d2b3444b6508dc449f22fff9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -97 lines) Patch
M sky/engine/core/rendering/RenderBox.h View 4 chunks +9 lines, -0 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 11 chunks +59 lines, -20 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 6 chunks +1 line, -20 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 6 chunks +8 lines, -50 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerClipper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
eseidel
lgtm
5 years, 9 months ago (2015-02-28 01:16:35 UTC) #2
ojan
5 years, 9 months ago (2015-02-28 01:18:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6a0dc6aa73140057d2b3444b6508dc449f22fff9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698