Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 969353004: [Android] Cache function templates in GinJavaBridgeObject to avoid memory leak (Closed)

Created:
5 years, 9 months ago by mnaganov (inactive)
Modified:
5 years, 9 months ago
Reviewers:
Torne
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Cache function templates in GinJavaBridgeObject to avoid memory leak V8 caches all function templates internally for the lifetime of a web page in an unbounded cache. Thus, creating a new function template for each call to a method of injected object caused JS heap memory to grow linearly. This is similar to a fix for Pepper Plugin objects (https://codereview.chromium.org/785213002/) BUG=462664 Committed: https://crrev.com/8f8de9cf6f95d27dd01b834f2fabcc8389315d37 Cr-Commit-Position: refs/heads/master@{#318890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M content/renderer/java/gin_java_bridge_object.h View 3 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/java/gin_java_bridge_object.cc View 3 chunks +18 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mnaganov (inactive)
PTAL. No tests added because the internal V8 cache is, well, internal, and we can't ...
5 years, 9 months ago (2015-03-03 12:51:13 UTC) #2
Torne
lgtm
5 years, 9 months ago (2015-03-03 13:45:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969353004/1
5 years, 9 months ago (2015-03-03 13:46:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 16:35:50 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 16:36:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f8de9cf6f95d27dd01b834f2fabcc8389315d37
Cr-Commit-Position: refs/heads/master@{#318890}

Powered by Google App Engine
This is Rietveld 408576698