Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 785213002: Cache function templates in PluginObject to avoid memory leak. (Closed)

Created:
6 years ago by ulan
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cache function templates in PluginObject to avoid memory leak. Without caching, each call to PluginObject::GetPropertyOrMethod creates a new function template. V8 stores all function templates internally for the lifetime of the web-page. BUG=439966 Committed: https://crrev.com/e85e45ea01bd4aeef48bf991012b198f7316470c Cr-Commit-Position: refs/heads/master@{#307691}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M content/renderer/pepper/plugin_object.h View 3 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/pepper/plugin_object.cc View 3 chunks +17 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
ulan
PTAL
6 years ago (2014-12-09 09:47:11 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years ago (2014-12-09 15:57:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785213002/1
6 years ago (2014-12-10 09:58:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/16669)
6 years ago (2014-12-10 11:28:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785213002/1
6 years ago (2014-12-10 12:36:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785213002/20001
6 years ago (2014-12-10 12:43:10 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-10 13:41:27 UTC) #13
commit-bot: I haz the power
6 years ago (2014-12-10 13:42:03 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e85e45ea01bd4aeef48bf991012b198f7316470c
Cr-Commit-Position: refs/heads/master@{#307691}

Powered by Google App Engine
This is Rietveld 408576698