Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 969223002: Autofill wallet -- handle several classes of error in unmasking prompt. (Closed)

Created:
5 years, 9 months ago by Evan Stade
Modified:
5 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill/Wallet -- handle several classes of error in unmasking prompt. (Views only for now.) BUG=463291 Committed: https://crrev.com/fb1d7742a2c6784f50ee723b8c0ce67239fa8173 Cr-Commit-Position: refs/heads/master@{#318821}

Patch Set 1 #

Patch Set 2 : remote debugging of compile failures #

Patch Set 3 : local #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -75 lines) Patch
M android_webview/native/aw_autofill_client.h View 1 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_autofill_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc View 1 chunk +33 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/card_unmask_prompt_view.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/chrome_autofill_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/chrome_autofill_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc View 6 chunks +32 lines, -23 lines 0 comments Download
M components/autofill/core/browser/autofill_client.h View 2 chunks +16 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics_unittest.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M components/autofill/core/browser/test_autofill_client.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/test_autofill_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/wallet/real_pan_wallet_client.h View 2 chunks +3 lines, -1 line 0 comments Download
M components/autofill/core/browser/wallet/real_pan_wallet_client.cc View 5 chunks +28 lines, -28 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Evan Stade
5 years, 9 months ago (2015-03-02 23:41:48 UTC) #2
brettw
lgtm
5 years, 9 months ago (2015-03-02 23:54:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969223002/40001
5 years, 9 months ago (2015-03-03 02:00:33 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-03 02:57:30 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 02:58:03 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fb1d7742a2c6784f50ee723b8c0ce67239fa8173
Cr-Commit-Position: refs/heads/master@{#318821}

Powered by Google App Engine
This is Rietveld 408576698