Autofill wallet -- handle several classes of error in unmasking prompt.

chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_models.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_types.h"
 #include "chrome/browser/ui/autofill/card_unmask_prompt_controller.h"
 #include "chrome/browser/ui/autofill/card_unmask_prompt_view.h"
 #include "chrome/browser/ui/views/autofill/decorated_textfield.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/constrained_window/constrained_window_views.h"
+#include "components/web_modal/web_contents_modal_dialog_host.h"
+#include "components/web_modal/web_contents_modal_dialog_manager.h"
+#include "components/web_modal/web_contents_modal_dialog_manager_delegate.h"
 #include "grit/theme_resources.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/views/background.h"
 #include "ui/views/controls/button/checkbox.h"
 #include "ui/views/controls/combobox/combobox.h"
 #include "ui/views/controls/combobox/combobox_listener.h"
 #include "ui/views/controls/image_view.h"
 #include "ui/views/controls/label.h"
@@ skipping 39 matching lines @@
     ClosePrompt();
   }
 
   void DisableAndWaitForVerification() override {
     SetInputsEnabled(false);
     progress_overlay_->SetVisible(true);
     GetDialogClientView()->UpdateDialogButtons();
     Layout();
   }
 
-  void GotVerificationResult(bool success) override {
-    if (success) {
+  void GotVerificationResult(const base::string16& error_message,
+                             bool allow_retry) override {
+    if (!error_message.empty()) {
       progress_label_->SetText(base::ASCIIToUTF16("Success!"));
       base::MessageLoop::current()->PostDelayedTask(
           FROM_HERE, base::Bind(&CardUnmaskPromptViews::ClosePrompt,
                                 base::Unretained(this)),
           base::TimeDelta::FromSeconds(1));
     } else {
-      SetInputsEnabled(true);
-      SetInputsInvalid(true);
+      SetInputsEnabled(allow_retry);
+
+      // If there is more than one input showing, don't mark anything as invalid
+      // since we don't know the location of the problem.
+      if (controller_->ShouldRequestExpirationDate())
+        cvc_input_->SetInvalid(true);
+
       // TODO(estade): it's somewhat jarring when the error comes back too
       // quickly.
       progress_overlay_->SetVisible(false);
       // TODO(estade): When do we hide |error_label_|?
-      error_label_->SetText(
-          base::ASCIIToUTF16("Verification error. Please try again."));
+      error_label_->SetMultiLine(true);
+      error_label_->SetText(error_message);
+
+      // Update the dialog's size, which may change depending on
+      // |error_message|.
+      if (GetWidget() && controller_->GetWebContents()) {
+        constrained_window::UpdateWebContentsModalDialogPosition(
+            GetWidget(),
+            web_modal::WebContentsModalDialogManager::FromWebContents(
+                controller_->GetWebContents())
+                ->delegate()
+                ->GetWebContentsModalDialogHost());
+      }
       GetDialogClientView()->UpdateDialogButtons();
     }
+
     Layout();
   }
 
   void SetInputsEnabled(bool enabled) {
     cvc_input_->SetEnabled(enabled);
+    storage_checkbox_->SetEnabled(enabled);
 
     if (month_input_)
       month_input_->SetEnabled(enabled);
     if (year_input_)
       year_input_->SetEnabled(enabled);
   }
 
-  void SetInputsInvalid(bool invalid) {
-    cvc_input_->SetInvalid(invalid);
-
-    if (month_input_)
-      month_input_->SetInvalid(invalid);
-    if (year_input_)
-      year_input_->SetInvalid(invalid);
-  }
-
   // views::DialogDelegateView
   View* GetContentsView() override {
     InitIfNecessary();
     return this;
   }
 
   // views::View
   gfx::Size GetPreferredSize() const override {
     // Must hardcode a width so the label knows where to wrap. TODO(estade):
     // This can lead to a weird looking dialog if we end up getting allocated
     // more width than we ask for, e.g. if the title is super long.
-    const int kWidth = 250;
+    const int kWidth = 450;
     return gfx::Size(kWidth, GetHeightForWidth(kWidth));
   }
 
   void Layout() override {
     for (int i = 0; i < child_count(); ++i) {
       child_at(i)->SetBoundsRect(GetContentsBounds());
     }
   }
 
   int GetHeightForWidth(int width) const override {
@@ skipping 68 matching lines @@
         year_input_
             ? year_combobox_model_.GetItemAt(year_input_->selected_index())
             : base::string16(),
         storage_checkbox_ ? storage_checkbox_->checked() : false);
     return false;
   }
 
   // views::TextfieldController
   void ContentsChanged(views::Textfield* sender,
                        const base::string16& new_contents) override {
-    // Sets all inputs back to valid since we don't know which one was
-    // actually invalid to begin with.
-    SetInputsInvalid(false);
+    cvc_input_->SetInvalid(false);
     GetDialogClientView()->UpdateDialogButtons();
   }
 
   // views::ComboboxListener
   void OnPerformAction(views::Combobox* combobox) override {
-    // Sets all inputs back to valid since we don't know which one was
-    // actually invalid to begin with.
-    SetInputsInvalid(false);
+    combobox->SetInvalid(false);
     GetDialogClientView()->UpdateDialogButtons();
   }
 
  private:
   void InitIfNecessary() {
     if (has_children())
       return;
 
     controls_container_ = new views::View();
     controls_container_->SetLayoutManager(
@@ skipping 28 matching lines @@
     cvc_input_->set_default_width_in_chars(10);
     input_row->AddChildView(cvc_input_);
 
     views::ImageView* cvc_image = new views::ImageView();
     ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
 
     cvc_image->SetImage(rb.GetImageSkiaNamed(controller_->GetCvcImageRid()));
 
     input_row->AddChildView(cvc_image);
 
-    // Reserve vertical space.
+    // Reserve vertical space for the error label, assuming it's one line.
     error_label_ = new views::Label(base::ASCIIToUTF16(" "));
     error_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
     error_label_->SetEnabledColor(kWarningColor);
     controls_container_->AddChildView(error_label_);
 
     storage_checkbox_ = new views::Checkbox(l10n_util::GetStringUTF16(
         IDS_AUTOFILL_CARD_UNMASK_PROMPT_STORAGE_CHECKBOX));
     storage_checkbox_->SetChecked(controller_->GetStoreLocallyStartState());
     controls_container_->AddChildView(storage_checkbox_);
 
@@ skipping 42 matching lines @@
 
 // static
 CardUnmaskPromptView* CardUnmaskPromptView::CreateAndShow(
     CardUnmaskPromptController* controller) {
   CardUnmaskPromptViews* view = new CardUnmaskPromptViews(controller);
   view->Show();
   return view;
 }
 
 }  // namespace autofill