components/autofill/core/browser/autofill_metrics_unittest.cc - Issue 969223002: Autofill wallet -- handle several classes of error in unmasking prompt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_metrics_unittest.cc

Issue 969223002: Autofill wallet -- handle several classes of error in unmasking prompt. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: local Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_manager.cc ('k') | components/autofill/core/browser/test_autofill_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_metrics_unittest.cc

diff --git a/components/autofill/core/browser/autofill_metrics_unittest.cc b/components/autofill/core/browser/autofill_metrics_unittest.cc

index f249d0882440e9322da61813d3e7416fc9bcc1ee..04ff3069b42d62c1c69cab6e5198dbb8ac4f598c 100644

--- a/components/autofill/core/browser/autofill_metrics_unittest.cc

+++ b/components/autofill/core/browser/autofill_metrics_unittest.cc

@@ -1186,7 +1186,8 @@ TEST_F(AutofillMetricsTest, CreditCardFilledFormEvents) {

AutofillDriver::FORM_DATA_ACTION_FILL,

0, form, form.fields.front(),

autofill_manager_->MakeFrontendID(guid, SuggestionBackendID()));

- autofill_manager_->OnDidGetRealPan("6011000990139424");

+ autofill_manager_->OnDidGetRealPan(AutofillClient::SUCCESS,

+ "6011000990139424");

histogram_tester.ExpectBucketCount(

"Autofill.FormEvents.CreditCard",

AutofillMetrics::FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_FILLED, 1);

@@ -1348,7 +1349,8 @@ TEST_F(AutofillMetricsTest, CreditCardSubmittedFormEvents) {