mojo/dart/test/bindings_generation_test.dart - Issue 968243003: Dart: Adds optional named arguments for creating bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/dart/test/bindings_generation_test.dart

Issue 968243003: Dart: Adds optional named arguments for creating bindings. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Binding -> Stub, delegate -> impl Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/dart/test/bindings_generation_test.dart

diff --git a/mojo/dart/test/bindings_generation_test.dart b/mojo/dart/test/bindings_generation_test.dart

index e1bddef2434b9bab8d4d8973ea0e96307de02441..a83930b1aa52cff84d6feced9292b63ffffe467f 100644

--- a/mojo/dart/test/bindings_generation_test.dart

+++ b/mojo/dart/test/bindings_generation_test.dart

@@ -17,9 +17,8 @@ class ProviderImpl implements sample.Provider {

sample.ProviderStub _stub;

ProviderImpl(core.MojoMessagePipeEndpoint endpoint) {

- _stub = new sample.ProviderStub.fromEndpoint(endpoint)

- ..delegate = this

- ..listen();

+ _stub = new sample.ProviderStub.fromEndpoint(

+ endpoint, impl: this);

}

echoString(String a, Function responseFactory) =>