mojo/dart/embedder/test/dart_to_cpp_tests.dart - Issue 968243003: Dart: Adds optional named arguments for creating bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/dart/embedder/test/dart_to_cpp_tests.dart

Issue 968243003: Dart: Adds optional named arguments for creating bindings. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Binding -> Stub, delegate -> impl Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/dart/embedder/test/dart_to_cpp_tests.dart

diff --git a/mojo/dart/embedder/test/dart_to_cpp_tests.dart b/mojo/dart/embedder/test/dart_to_cpp_tests.dart

index c93d82d4e9f89302fdb30de5ad6fd3e63a02d501..f9621ae01502539f8c4734c498b760f914d952e0 100644

--- a/mojo/dart/embedder/test/dart_to_cpp_tests.dart

+++ b/mojo/dart/embedder/test/dart_to_cpp_tests.dart

@@ -22,9 +22,7 @@ class DartSideImpl implements DartSide {

Completer _completer;

DartSideImpl(core.MojoMessagePipeEndpoint endpoint) {

- _stub = new DartSideStub.fromEndpoint(endpoint)

- ..delegate = this

- ..listen();

+ _stub = new DartSideStub.fromEndpoint(endpoint, impl: this);

_sampleData = new Uint8List(CAPACITY_BYTES);

for (int i = 0; i < _sampleData.length; ++i) {

_sampleData[i] = i;