Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Unified Diff: examples/dart/hello_world/hello/main.dart

Issue 968243003: Dart: Adds optional named arguments for creating bindings. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Binding -> Stub, delegate -> impl Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: examples/dart/hello_world/hello/main.dart
diff --git a/examples/dart/hello_world/hello/main.dart b/examples/dart/hello_world/hello/main.dart
index 4dcbd4c86614081d699517f8d177cc5131559b46..40849f976169e06c497de1aff2a927f40f3bf442 100644
--- a/examples/dart/hello_world/hello/main.dart
+++ b/examples/dart/hello_world/hello/main.dart
@@ -16,8 +16,8 @@ class Hello extends Application {
print("$url Hello");
// We expect to find the world mojo application at the same
// path as this application.
- connectToApplication(url.replaceAll("hello", "world"));
- close();
+ var c = connectToApplication(url.replaceAll("hello", "world"));
+ c.listen(onClosed: close);
hansmuller1 2015/03/03 20:32:16 I like this. It's subtly different from the origi
zra 2015/03/03 21:28:54 Added comment.
}
}
« no previous file with comments | « no previous file | mojo/dart/embedder/test/dart_to_cpp_tests.dart » ('j') | mojo/public/dart/src/application.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698