Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 967543002: [S.P.] Move svg mask painting to SVGMaskPainter (Closed)

Created:
5 years, 9 months ago by Erik Dahlström (inactive)
Modified:
5 years, 9 months ago
Reviewers:
pdr., fs
CC:
blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, Dominik Röttsches, dshwang, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[S.P.] Move mask painting to SVGMaskPainter. BUG=462077 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191196

Patch Set 1 #

Patch Set 2 : move drawMaskForRenderer too #

Total comments: 9

Patch Set 3 : review fixes #

Patch Set 4 : expose clearInvalidationMask #

Total comments: 4

Patch Set 5 : review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -87 lines) Patch
M Source/core/core.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceContainer.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceMasker.h View 1 2 3 4 3 chunks +3 lines, -4 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceMasker.cpp View 1 2 3 4 3 chunks +16 lines, -79 lines 0 comments Download
A Source/core/paint/SVGMaskPainter.h View 1 2 3 4 1 chunk +32 lines, -0 lines 0 comments Download
A Source/core/paint/SVGMaskPainter.cpp View 1 2 3 4 1 chunk +84 lines, -0 lines 0 comments Download
M Source/core/paint/SVGPaintContext.cpp View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Erik Dahlström (inactive)
A first attempt at breaking out the painting parts of <mask>, PTAL.
5 years, 9 months ago (2015-03-02 08:49:53 UTC) #2
fs
https://codereview.chromium.org/967543002/diff/20001/Source/core/layout/svg/LayoutSVGResourceMasker.cpp File Source/core/layout/svg/LayoutSVGResourceMasker.cpp (right): https://codereview.chromium.org/967543002/diff/20001/Source/core/layout/svg/LayoutSVGResourceMasker.cpp#newcode26 Source/core/layout/svg/LayoutSVGResourceMasker.cpp:26: #include "core/paint/TransformRecorder.h" Still needed? Same for DrawingDisplayItem.h. https://codereview.chromium.org/967543002/diff/20001/Source/core/layout/svg/LayoutSVGResourceMasker.h File ...
5 years, 9 months ago (2015-03-02 13:24:51 UTC) #3
pdr.
https://codereview.chromium.org/967543002/diff/20001/Source/core/paint/SVGMaskPainter.cpp File Source/core/paint/SVGMaskPainter.cpp (right): https://codereview.chromium.org/967543002/diff/20001/Source/core/paint/SVGMaskPainter.cpp#newcode78 Source/core/paint/SVGMaskPainter.cpp:78: if (!m_mask.m_maskContentPicture) { On 2015/03/02 at 13:24:51, fs wrote: ...
5 years, 9 months ago (2015-03-02 18:57:35 UTC) #4
Erik Dahlström (inactive)
The remaining call to (private method) LayoutSVGResourceMasker.clearInvalidationMask() was converted into an assert checking that the ...
5 years, 9 months ago (2015-03-03 08:42:58 UTC) #5
Erik Dahlström (inactive)
On 2015/03/03 08:42:58, Erik Dahlström wrote: > The remaining call to (private method) > LayoutSVGResourceMasker.clearInvalidationMask() ...
5 years, 9 months ago (2015-03-03 10:29:26 UTC) #6
fs
lgtm https://codereview.chromium.org/967543002/diff/60001/Source/core/layout/svg/LayoutSVGResourceMasker.h File Source/core/layout/svg/LayoutSVGResourceMasker.h (right): https://codereview.chromium.org/967543002/diff/60001/Source/core/layout/svg/LayoutSVGResourceMasker.h#newcode58 Source/core/layout/svg/LayoutSVGResourceMasker.h:58: PassRefPtr<const SkPicture> setupDrawMaskForRenderer(AffineTransform&, const FloatRect&); I think I ...
5 years, 9 months ago (2015-03-03 12:04:37 UTC) #7
Erik Dahlström (inactive)
https://codereview.chromium.org/967543002/diff/60001/Source/core/layout/svg/LayoutSVGResourceMasker.h File Source/core/layout/svg/LayoutSVGResourceMasker.h (right): https://codereview.chromium.org/967543002/diff/60001/Source/core/layout/svg/LayoutSVGResourceMasker.h#newcode58 Source/core/layout/svg/LayoutSVGResourceMasker.h:58: PassRefPtr<const SkPicture> setupDrawMaskForRenderer(AffineTransform&, const FloatRect&); On 2015/03/03 12:04:37, fs ...
5 years, 9 months ago (2015-03-03 13:08:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967543002/80001
5 years, 9 months ago (2015-03-03 13:10:13 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 15:29:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191196

Powered by Google App Engine
This is Rietveld 408576698