Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Unified Diff: Source/core/layout/svg/LayoutSVGResourceMasker.cpp

Issue 967543002: [S.P.] Move svg mask painting to SVGMaskPainter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: review fixes Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/svg/LayoutSVGResourceMasker.h ('k') | Source/core/paint/SVGMaskPainter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/svg/LayoutSVGResourceMasker.cpp
diff --git a/Source/core/layout/svg/LayoutSVGResourceMasker.cpp b/Source/core/layout/svg/LayoutSVGResourceMasker.cpp
index 27a5d949e9cde219f67ad6459029ed32c4060c3e..0cb26dd53c50e2dd0b254cf4ae2e152d73b874ec 100644
--- a/Source/core/layout/svg/LayoutSVGResourceMasker.cpp
+++ b/Source/core/layout/svg/LayoutSVGResourceMasker.cpp
@@ -22,13 +22,9 @@
#include "core/dom/ElementTraversal.h"
#include "core/layout/svg/SVGLayoutSupport.h"
-#include "core/paint/CompositingRecorder.h"
#include "core/paint/SVGPaintContext.h"
-#include "core/paint/TransformRecorder.h"
#include "core/svg/SVGElement.h"
-#include "platform/graphics/paint/CompositingDisplayItem.h"
#include "platform/graphics/paint/DisplayItemList.h"
-#include "platform/graphics/paint/DrawingDisplayItem.h"
#include "platform/transforms/AffineTransform.h"
#include "third_party/skia/include/core/SkPicture.h"
@@ -56,81 +52,6 @@ void LayoutSVGResourceMasker::removeClientFromCache(LayoutObject* client, bool m
markClientForInvalidation(client, markForInvalidation ? BoundariesInvalidation : ParentOnlyInvalidation);
}
-bool LayoutSVGResourceMasker::prepareEffect(LayoutObject* object, GraphicsContext* context)
-{
- ASSERT(object);
- ASSERT(context);
- ASSERT(style());
- ASSERT_WITH_SECURITY_IMPLICATION(!needsLayout());
-
- clearInvalidationMask();
-
- FloatRect paintInvalidationRect = object->paintInvalidationRectInLocalCoordinates();
- if (paintInvalidationRect.isEmpty() || !element()->hasChildren())
- return false;
-
- if (RuntimeEnabledFeatures::slimmingPaintEnabled()) {
- ASSERT(context->displayItemList());
- context->displayItemList()->add(BeginCompositingDisplayItem::create(object->displayItemClient(), WebCoreCompositeToSkiaComposite(context->compositeOperationDeprecated(), WebBlendModeNormal), 1, &paintInvalidationRect));
- } else {
- BeginCompositingDisplayItem beginCompositingContent(object->displayItemClient(), WebCoreCompositeToSkiaComposite(context->compositeOperationDeprecated(), WebBlendModeNormal), 1, &paintInvalidationRect);
- beginCompositingContent.replay(context);
- }
-
- return true;
-}
-
-void LayoutSVGResourceMasker::finishEffect(LayoutObject* object, GraphicsContext* context)
-{
- ASSERT(object);
- ASSERT(context);
- ASSERT(style());
- ASSERT_WITH_SECURITY_IMPLICATION(!needsLayout());
-
- FloatRect paintInvalidationRect = object->paintInvalidationRectInLocalCoordinates();
- {
- ColorFilter maskLayerFilter = style()->svgStyle().maskType() == MT_LUMINANCE
- ? ColorFilterLuminanceToAlpha : ColorFilterNone;
- CompositingRecorder maskCompositing(context, object->displayItemClient(), SkXfermode::kDstIn_Mode, 1, &paintInvalidationRect, maskLayerFilter);
- drawMaskForRenderer(context, object->displayItemClient(), object->objectBoundingBox());
- }
-
- if (RuntimeEnabledFeatures::slimmingPaintEnabled()) {
- ASSERT(context->displayItemList());
- context->displayItemList()->add(EndCompositingDisplayItem::create(object->displayItemClient()));
- } else {
- EndCompositingDisplayItem endCompositingContent(object->displayItemClient());
- endCompositingContent.replay(context);
- }
-}
-
-void LayoutSVGResourceMasker::drawMaskForRenderer(GraphicsContext* context, DisplayItemClient client, const FloatRect& targetBoundingBox)
-{
- ASSERT(context);
-
- AffineTransform contentTransformation;
- SVGUnitTypes::SVGUnitType contentUnits = toSVGMaskElement(element())->maskContentUnits()->currentValue()->enumValue();
- if (contentUnits == SVGUnitTypes::SVG_UNIT_TYPE_OBJECTBOUNDINGBOX) {
- contentTransformation.translate(targetBoundingBox.x(), targetBoundingBox.y());
- contentTransformation.scaleNonUniform(targetBoundingBox.width(), targetBoundingBox.height());
- }
-
- if (!m_maskContentPicture) {
- SubtreeContentTransformScope contentTransformScope(contentTransformation);
- m_maskContentPicture = createContentPicture();
- }
-
- TransformRecorder recorder(*context, client, contentTransformation);
-
- if (RuntimeEnabledFeatures::slimmingPaintEnabled()) {
- ASSERT(context->displayItemList());
- context->displayItemList()->add(DrawingDisplayItem::create(client, DisplayItem::SVGMask, m_maskContentPicture));
- } else {
- DrawingDisplayItem maskPicture(client, DisplayItem::SVGMask, m_maskContentPicture);
- maskPicture.replay(context);
- }
-}
-
PassRefPtr<const SkPicture> LayoutSVGResourceMasker::createContentPicture()
{
// Using strokeBoundingBox (instead of paintInvalidationRectInLocalCoordinates) to avoid the intersection
@@ -164,6 +85,22 @@ PassRefPtr<const SkPicture> LayoutSVGResourceMasker::createContentPicture()
return context.endRecording();
}
+PassRefPtr<const SkPicture> LayoutSVGResourceMasker::getContentPicture(AffineTransform& contentTransformation, const FloatRect& targetBoundingBox)
+{
+ SVGUnitTypes::SVGUnitType contentUnits = toSVGMaskElement(element())->maskContentUnits()->currentValue()->enumValue();
+ if (contentUnits == SVGUnitTypes::SVG_UNIT_TYPE_OBJECTBOUNDINGBOX) {
+ contentTransformation.translate(targetBoundingBox.x(), targetBoundingBox.y());
+ contentTransformation.scaleNonUniform(targetBoundingBox.width(), targetBoundingBox.height());
+ }
+
+ if (!m_maskContentPicture) {
+ SubtreeContentTransformScope contentTransformScope(contentTransformation);
+ m_maskContentPicture = createContentPicture();
+ }
+
+ return m_maskContentPicture;
+}
+
void LayoutSVGResourceMasker::calculateMaskContentPaintInvalidationRect()
{
for (SVGElement* childElement = Traversal<SVGElement>::firstChild(*element()); childElement; childElement = Traversal<SVGElement>::nextSibling(*childElement)) {
« no previous file with comments | « Source/core/layout/svg/LayoutSVGResourceMasker.h ('k') | Source/core/paint/SVGMaskPainter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698