Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: Source/web/WebAXObject.cpp

Issue 967213004: Removed FrameView's windowToContents and contentsToWindow methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/ValidationMessageClientImpl.cpp ('k') | Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebAXObject.cpp
diff --git a/Source/web/WebAXObject.cpp b/Source/web/WebAXObject.cpp
index 38612586cb033948d64bae7538c3bc98322db8f6..5dca5777bda07647665f815eb46fb2264c72414c 100644
--- a/Source/web/WebAXObject.cpp
+++ b/Source/web/WebAXObject.cpp
@@ -707,15 +707,7 @@ WebAXObject WebAXObject::hitTest(const WebPoint& point) const
if (isDetached())
return WebAXObject();
- // FIXME: This is being cleaned up in https://codereview.chromium.org/967213004/ to use
- // centralized methods to convert between coordinate spaces. However, this is a bug that needs
- // to be merged back to M42 so it needs an isolated, low-impact fix. This hack will be removed
- // in the above CL.
- PinchViewport& pinchViewport = m_private->documentFrameView()->page()->frameHost().pinchViewport();
- FloatPoint pointInRootFrame(point.x, point.y);
- pointInRootFrame.moveBy(pinchViewport.location());
-
- IntPoint contentsPoint = m_private->documentFrameView()->windowToContents(flooredIntPoint(pointInRootFrame));
+ IntPoint contentsPoint = m_private->documentFrameView()->soonToBeRemovedUnscaledViewportToContents(point);
RefPtr<AXObject> hit = m_private->accessibilityHitTest(contentsPoint);
if (hit)
« no previous file with comments | « Source/web/ValidationMessageClientImpl.cpp ('k') | Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698