Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: Source/web/WebDevToolsAgentImpl.cpp

Issue 967213004: Removed FrameView's windowToContents and contentsToWindow methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebAXObject.cpp ('k') | Source/web/WebFrameWidgetImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebDevToolsAgentImpl.cpp
diff --git a/Source/web/WebDevToolsAgentImpl.cpp b/Source/web/WebDevToolsAgentImpl.cpp
index 8ca298f3078fe3a2e308690d5e61a28946f02bc7..6cc5076d6a4ce8c751615564094ced1e1e81bc22 100644
--- a/Source/web/WebDevToolsAgentImpl.cpp
+++ b/Source/web/WebDevToolsAgentImpl.cpp
@@ -609,7 +609,7 @@ void WebDevToolsAgentImpl::dispatchMessageFromFrontend(const String& message)
m_inspectorBackendDispatcher->dispatch(message);
}
-void WebDevToolsAgentImpl::inspectElementAt(const WebPoint& point)
+void WebDevToolsAgentImpl::inspectElementAt(const WebPoint& pointInRootFrame)
{
Page* page = m_webViewImpl->page();
if (!page)
@@ -619,10 +619,10 @@ void WebDevToolsAgentImpl::inspectElementAt(const WebPoint& point)
HitTestRequest request(hitType);
WebMouseEvent dummyEvent;
dummyEvent.type = WebInputEvent::MouseDown;
- dummyEvent.x = point.x;
- dummyEvent.y = point.y;
+ dummyEvent.x = pointInRootFrame.x;
+ dummyEvent.y = pointInRootFrame.y;
IntPoint transformedPoint = PlatformMouseEventBuilder(page->deprecatedLocalMainFrame()->view(), dummyEvent).position();
- HitTestResult result(page->deprecatedLocalMainFrame()->view()->windowToContents(transformedPoint));
+ HitTestResult result(page->deprecatedLocalMainFrame()->view()->rootFrameToContents(transformedPoint));
page->deprecatedLocalMainFrame()->contentRenderer()->hitTest(request, result);
Node* node = result.innerNode();
if (!node && page->deprecatedLocalMainFrame()->document())
« no previous file with comments | « Source/web/WebAXObject.cpp ('k') | Source/web/WebFrameWidgetImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698