Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1764)

Unified Diff: Source/web/ValidationMessageClientImpl.cpp

Issue 967213004: Removed FrameView's windowToContents and contentsToWindow methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/TextFinder.cpp ('k') | Source/web/WebAXObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/ValidationMessageClientImpl.cpp
diff --git a/Source/web/ValidationMessageClientImpl.cpp b/Source/web/ValidationMessageClientImpl.cpp
index da3b66a16313f38e40b262c3e1c9705150e078a8..c661a3e5da98e380adc871d4f5726964ecf47e1c 100644
--- a/Source/web/ValidationMessageClientImpl.cpp
+++ b/Source/web/ValidationMessageClientImpl.cpp
@@ -73,7 +73,7 @@ void ValidationMessageClientImpl::showValidationMessage(const Element& anchor, c
if (m_currentAnchor)
hideValidationMessage(*m_currentAnchor);
m_currentAnchor = &anchor;
- IntRect anchorInViewport = currentView()->contentsToWindow(anchor.pixelSnappedBoundingBox());
+ IntRect anchorInViewport = currentView()->contentsToViewport(anchor.pixelSnappedBoundingBox());
m_lastAnchorRectInScreen = currentView()->hostWindow()->viewportToScreen(anchorInViewport);
m_lastPageScaleFactor = m_webView.pageScaleFactor();
m_message = message;
@@ -122,7 +122,7 @@ void ValidationMessageClientImpl::checkAnchorStatus(Timer<ValidationMessageClien
// Check the visibility of the element.
// FIXME: Can we check invisibility by scrollable non-frame elements?
- IntRect newAnchorRectInViewport = currentView()->contentsToWindow(m_currentAnchor->pixelSnappedBoundingBox());
+ IntRect newAnchorRectInViewport = currentView()->contentsToViewport(m_currentAnchor->pixelSnappedBoundingBox());
// FIXME: This intersection eliminates the part of the rect outside the root view.
// If this is meant as a visiblity test, intersecting it against the viewport rect
« no previous file with comments | « Source/web/TextFinder.cpp ('k') | Source/web/WebAXObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698