use colorfilter instead of imagefilter when possible

use colorfilter instead of imagefilter when possible

big speed win w/ nanobench --match colorfilter_

BUG=skia:
TBR=

Will require rebaselining, so landing temporarily to trigger layouttests.

Committed: https://skia.googlesource.com/skia/+/f641bd076d29666a5d2a10d5384e4924b0a0e524

[reed2, 2015-03-01 19:13:41]

reed@chromium.org changed reviewers:
+ bsalomon@google.com, senorblanco@google.com, sugoi@google.com

[reed2, 2015-03-01 19:13:52]

reed@chromium.org changed reviewers:
+ reed@google.com

[Stephen White, 2015-03-02 18:50:21]

senorblanco@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2015-03-02 18:50:22]

https://codereview.chromium.org/966233002/diff/40001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/966233002/diff/40001/src/core/SkCanvas.cpp#ne...
src/core/SkCanvas.cpp:309: if (NULL == paintCF &&
fOrigPaint.getImageFilter()->asColorFilter(&embeddedCF)) {
Need to check for !getInput(0) here?

[reed2, 2015-03-08 21:39:45]

ptal

https://codereview.chromium.org/966233002/diff/40001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/966233002/diff/40001/src/core/SkCanvas.cpp#ne...
src/core/SkCanvas.cpp:309: if (NULL == paintCF &&
fOrigPaint.getImageFilter()->asColorFilter(&embeddedCF)) {
On 2015/03/02 18:50:22, Stephen White wrote:
> Need to check for !getInput(0) here?

asAColorFilter takes care of that check.

[reed2, 2015-03-08 21:39:49]

The CQ bit was checked by reed@chromium.org

[commit-bot: I haz the power, 2015-03-08 21:40:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/966233002/80001

[commit-bot: I haz the power, 2015-03-08 21:40:42]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-03-09 03:40 UTC

[reed2, 2015-03-08 21:43:08]

The CQ bit was unchecked by reed@chromium.org

[reed2, 2015-03-08 23:52:05]

The CQ bit was checked by reed@chromium.org

[commit-bot: I haz the power, 2015-03-08 23:52:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/966233002/100001

[commit-bot: I haz the power, 2015-03-08 23:52:38]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-03-09 05:52 UTC

[reed2, 2015-03-09 01:34:17]

The CQ bit was unchecked by reed@chromium.org

[reed2, 2015-03-09 01:34:22]

The CQ bit was checked by reed@chromium.org

[commit-bot: I haz the power, 2015-03-09 01:34:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/966233002/100001

[commit-bot: I haz the power, 2015-03-09 01:34:41]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/f641bd076d29666a5d2a10d5384e4924b0a0e524

[reed2, 2015-03-09 01:46:25]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/991693002/ by reed@chromium.org.

The reason for reverting is: Lots of PDF failures -- need to investigate.