Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 965723002: Ensure we can reliably check the cell for validity of global property (Closed)

Created:
5 years, 9 months ago by Toon Verwaest
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ensure we can reliably check the cell for validity of global property [Closed since it was superseded by https://codereview.chromium.org/996133002] BUG=

Patch Set 1 #

Patch Set 2 : Check global proxy map rather than global object #

Patch Set 3 : Check global object rather than map #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -116 lines) Patch
M src/code-stubs.h View 1 2 1 chunk +5 lines, -15 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 2 1 chunk +8 lines, -10 lines 0 comments Download
M src/deoptimizer.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M src/ic/handler-compiler.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M src/ic/ic.cc View 1 2 4 chunks +11 lines, -12 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M src/lookup.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 2 3 6 chunks +44 lines, -40 lines 0 comments Download
A test/mjsunit/regress/convert-global-data-to-accessor.js View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Toon Verwaest
PTAL dslomov: fyi
5 years, 9 months ago (2015-02-27 12:01:50 UTC) #2
ulan
lgtm
5 years, 9 months ago (2015-02-27 12:07:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965723002/1
5 years, 9 months ago (2015-02-27 12:18:59 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 12:37:41 UTC) #7 
Try jobs failed on following builders:
  v8_win_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/3485)

Powered by Google App Engine
This is Rietveld 408576698