Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: src/code-stubs.h

Issue 965723002: Ensure we can reliably check the cell for validity of global property (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/code-stubs-hydrogen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 2ae4ba7085e37e1a10b3c0a73acd623034324ac5..e432c3adf9fda48485dec042d6a9472a1a408195 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -1120,21 +1120,11 @@ class StoreGlobalStub : public HandlerStub {
return isolate->factory()->uninitialized_value();
}
- Handle<Code> GetCodeCopyFromTemplate(Handle<GlobalObject> global,
- Handle<PropertyCell> cell) {
- if (check_global()) {
- Code::FindAndReplacePattern pattern;
- pattern.Add(isolate()->factory()->meta_map(),
- Map::WeakCellForMap(Handle<Map>(global->map())));
- pattern.Add(Handle<Map>(property_cell_placeholder(isolate())->map()),
- isolate()->factory()->NewWeakCell(cell));
- return CodeStub::GetCodeCopy(pattern);
- } else {
- Code::FindAndReplacePattern pattern;
- pattern.Add(Handle<Map>(property_cell_placeholder(isolate())->map()),
- isolate()->factory()->NewWeakCell(cell));
- return CodeStub::GetCodeCopy(pattern);
- }
+ Handle<Code> GetCodeCopyFromTemplate(Handle<PropertyCell> cell) {
+ Code::FindAndReplacePattern pattern;
+ pattern.Add(Handle<Map>(property_cell_placeholder(isolate())->map()),
+ isolate()->factory()->NewWeakCell(cell));
+ return CodeStub::GetCodeCopy(pattern);
}
Code::Kind kind() const OVERRIDE { return Code::STORE_IC; }
« no previous file with comments | « no previous file | src/code-stubs-hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698