src/ic/mips64/handler-compiler-mips64.cc - Issue 965723002: Ensure we can reliably check the cell for validity of global property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/mips64/handler-compiler-mips64.cc

Issue 965723002: Ensure we can reliably check the cell for validity of global property (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/mips64/handler-compiler-mips64.cc

diff --git a/src/ic/mips64/handler-compiler-mips64.cc b/src/ic/mips64/handler-compiler-mips64.cc

index 52204dd563355e139969bdb6d2e46a989ba74749..b7a26d5d96d7fa40a643dda16ad502579451e4bd 100644

--- a/src/ic/mips64/handler-compiler-mips64.cc

+++ b/src/ic/mips64/handler-compiler-mips64.cc

@@ -488,7 +488,8 @@ Register PropertyHandlerCompiler::CheckPrototypes(

// Log the check depth.

LOG(isolate(), IntEvent("check-maps-depth", depth + 1));

- if (depth != 0 || check == CHECK_ALL_MAPS) {

+ if (!current_map->IsJSGlobalObjectMap() &&

+ (depth != 0 || check == CHECK_ALL_MAPS)) {

// Check the holder map.

__ ld(scratch1, FieldMemOperand(reg, HeapObject::kMapOffset));

Handle<WeakCell> cell = Map::WeakCellForMap(current_map);

« no previous file with comments | « src/ic/mips/handler-compiler-mips.cc ('k') | src/ic/x64/handler-compiler-x64.cc » ('j') | no next file with comments »