Implement support for silent notifications.

Implement support for silent notifications.

On Android, notifications inherit the user's default settings in regards
to audibly notifying them about new notifications through sound (ringtone),
vibration and an indicator light, when present.

This patch implements support for silent notifications, which allow a Web
developer to set the "silent" key when creating a notification, that will
suppress these notifiers.

We currently don't have any audible notifiers on implementations which use
the Message Center, but it's feasible that this will become available in
the future. The Web Notification API specifies "sound" and "vibration"
fields as well, but we don't support these yet.

The Web Notification API specification:
  https://notifications.spec.whatwg.org/#object-members

This is part of a three-sided patch.
  [1] https://codereview.chromium.org/960163003/
  [2] This patch.
  [3] https://codereview.chromium.org/965463003/

BUG=442134
Committed: https://crrev.com/ad0c0d4798353820b218195b327dba3e422e5918
Cr-Commit-Position: refs/heads/master@{#319455}

[Peter Beverloo, 2015-02-26 22:36:49]

peter@chromium.org changed reviewers:
+ avi@chromium.org, dewittj@chromium.org, mkwst@chromium.org,
mvanouwerkerk@chromium.org

[Peter Beverloo, 2015-02-26 22:36:49]

+mvanouwerkerk and dewittj for review
+mkwst for IPC
+avi for content/public/

[Avi (use Gerrit), 2015-02-26 22:43:49]

content/public/ lgtm with fix.

https://codereview.chromium.org/965573002/diff/20001/content/public/common/pl...
File content/public/common/platform_notification_data.h (right):

https://codereview.chromium.org/965573002/diff/20001/content/public/common/pl...
content/public/common/platform_notification_data.h:50: // be surpressed.
suppressed

[Peter Beverloo, 2015-02-26 23:02:42]

Thanks!

https://codereview.chromium.org/965573002/diff/20001/content/public/common/pl...
File content/public/common/platform_notification_data.h (right):

https://codereview.chromium.org/965573002/diff/20001/content/public/common/pl...
content/public/common/platform_notification_data.h:50: // be surpressed.
On 2015/02/26 22:43:49, Avi wrote:
> suppressed

Done.

[Mike West, 2015-02-27 09:58:58]

IPC LGTM.

[Michael van Ouwerkerk, 2015-02-27 11:31:21]

lgtm

https://codereview.chromium.org/965573002/diff/40001/chrome/android/javatests...
File
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java
(right):

https://codereview.chromium.org/965573002/diff/40001/chrome/android/javatests...
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java:163:
// Zero indicates that no defaults should be inherit from the system.
nit: inherited

https://codereview.chromium.org/965573002/diff/40001/chrome/test/data/notific...
File chrome/test/data/notifications/platform_notification_service.html (right):

https://codereview.chromium.org/965573002/diff/40001/chrome/test/data/notific...
chrome/test/data/notifications/platform_notification_service.html:48: //
Displays a persistent notification having every field in it's options
nit of all nits: its

https://codereview.chromium.org/965573002/diff/40001/chrome/test/data/notific...
chrome/test/data/notifications/platform_notification_service.html:61: 
nit: one blank line is sufficient

[Peter Beverloo, 2015-02-27 12:26:29]

peter@chromium.org changed reviewers:
+ mukai@chromium.org

[Peter Beverloo, 2015-02-27 12:26:30]

Thanks Michael!

https://codereview.chromium.org/965573002/diff/40001/chrome/android/javatests...
File
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java
(right):

https://codereview.chromium.org/965573002/diff/40001/chrome/android/javatests...
chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java:163:
// Zero indicates that no defaults should be inherit from the system.
On 2015/02/27 11:31:21, Michael van Ouwerkerk wrote:
> nit: inherited

Done.

https://codereview.chromium.org/965573002/diff/40001/chrome/test/data/notific...
File chrome/test/data/notifications/platform_notification_service.html (right):

https://codereview.chromium.org/965573002/diff/40001/chrome/test/data/notific...
chrome/test/data/notifications/platform_notification_service.html:48: //
Displays a persistent notification having every field in it's options
On 2015/02/27 11:31:21, Michael van Ouwerkerk wrote:
> nit of all nits: its

Done.

https://codereview.chromium.org/965573002/diff/40001/chrome/test/data/notific...
chrome/test/data/notifications/platform_notification_service.html:61: 
On 2015/02/27 11:31:21, Michael van Ouwerkerk wrote:
> nit: one blank line is sufficient

Done.

[dewittj, 2015-02-27 19:09:32]

lgtm + nit

https://codereview.chromium.org/965573002/diff/60001/ui/message_center/notifi...
File ui/message_center/notification.h (right):

https://codereview.chromium.org/965573002/diff/60001/ui/message_center/notifi...
ui/message_center/notification.h:107: bool silent() const { return
optional_fields_.silent; }
Nit: comment that this field has no effect on non-Android platforms would be
cool.

[Peter Beverloo, 2015-03-02 19:04:35]

Thanks!

https://codereview.chromium.org/965573002/diff/60001/ui/message_center/notifi...
File ui/message_center/notification.h (right):

https://codereview.chromium.org/965573002/diff/60001/ui/message_center/notifi...
ui/message_center/notification.h:107: bool silent() const { return
optional_fields_.silent; }
On 2015/02/27 19:09:31, dewittj wrote:
> Nit: comment that this field has no effect on non-Android platforms would be
> cool.

Done.

[Peter Beverloo, 2015-03-06 14:48:32]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2015-03-06 14:48:33]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
mkwst@chromium.org, mvanouwerkerk@chromium.org, dewittj@chromium.org
Link to the patchset: https://codereview.chromium.org/965573002/#ps80001 (title:
"address justin's comment")

[commit-bot: I haz the power, 2015-03-06 14:49:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/965573002/80001

[Peter Beverloo, 2015-03-06 15:33:01]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2015-03-06 15:33:02]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
mkwst@chromium.org, mvanouwerkerk@chromium.org, dewittj@chromium.org
Link to the patchset: https://codereview.chromium.org/965573002/#ps100001
(title: "fix tests")

[commit-bot: I haz the power, 2015-03-06 15:33:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/965573002/100001

[commit-bot: I haz the power, 2015-03-06 16:27:49]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-03-06 16:29:13]

Patchset 6 (id:??) landed as
https://crrev.com/ad0c0d4798353820b218195b327dba3e422e5918
Cr-Commit-Position: refs/heads/master@{#319455}