chrome/browser/notifications/platform_notification_service_unittest.cc - Issue 965573002: Implement support for silent notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/platform_notification_service_unittest.cc

Issue 965573002: Implement support for silent notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/platform_notification_service_impl.cc ('k') | chrome/test/data/notifications/platform_notification_service.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/platform_notification_service_unittest.cc

diff --git a/chrome/browser/notifications/platform_notification_service_unittest.cc b/chrome/browser/notifications/platform_notification_service_unittest.cc

index 7145c26816b7202ef1c8caebcd248c72acda5ab1..55108c4b2381daa5fc6359c08b19759724b1e8dd 100644

--- a/chrome/browser/notifications/platform_notification_service_unittest.cc

+++ b/chrome/browser/notifications/platform_notification_service_unittest.cc

@@ -153,6 +153,7 @@ TEST_F(PlatformNotificationServiceTest, DisplayPageNotificationMatches) {

content::PlatformNotificationData notification_data;

notification_data.title = base::ASCIIToUTF16("My notification's title");

notification_data.body = base::ASCIIToUTF16("Hello, world!");

+ notification_data.silent = true;

MockDesktopNotificationDelegate* delegate

= new MockDesktopNotificationDelegate();

@@ -171,6 +172,7 @@ TEST_F(PlatformNotificationServiceTest, DisplayPageNotificationMatches) {

base::UTF16ToUTF8(notification.title()));

EXPECT_EQ("Hello, world!",

base::UTF16ToUTF8(notification.message()));

+ EXPECT_TRUE(notification.silent());

}

TEST_F(PlatformNotificationServiceTest, DisplayNameForOrigin) {