Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6343)

Unified Diff: chrome/browser/notifications/notification_ui_manager_android.cc

Issue 965573002: Implement support for silent notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix tests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_ui_manager_android.cc
diff --git a/chrome/browser/notifications/notification_ui_manager_android.cc b/chrome/browser/notifications/notification_ui_manager_android.cc
index 62aa950bc6cc5dff37c22183907191adbd9fe531..41d6b8d60e95152d8c074bfa5ca39952a4000ca7 100644
--- a/chrome/browser/notifications/notification_ui_manager_android.cc
+++ b/chrome/browser/notifications/notification_ui_manager_android.cc
@@ -59,6 +59,7 @@ scoped_ptr<Pickle> SerializePersistentNotification(
pickle->WriteString16(notification_data.body);
pickle->WriteString16(notification_data.tag);
pickle->WriteString(notification_data.icon.spec());
+ pickle->WriteBool(notification_data.silent);
// The origin which is displaying the notification.
pickle->WriteString(origin.spec());
@@ -89,7 +90,8 @@ bool UnserializePersistentNotification(
!iterator.ReadString(&notification_data->lang) ||
!iterator.ReadString16(&notification_data->body) ||
!iterator.ReadString16(&notification_data->tag) ||
- !iterator.ReadString(&icon_url)) {
+ !iterator.ReadString(&icon_url) ||
+ !iterator.ReadBool(&notification_data->silent)) {
return false;
}
@@ -274,8 +276,16 @@ void NotificationUIManagerAndroid::Add(const Notification& notification,
}
int platform_id = Java_NotificationUIManager_displayNotification(
- env, java_object_.obj(), tag.obj(), id.obj(), title.obj(), body.obj(),
- icon.obj(), origin.obj(), notification_data.obj());
+ env,
+ java_object_.obj(),
+ tag.obj(),
+ id.obj(),
+ title.obj(),
+ body.obj(),
+ icon.obj(),
+ origin.obj(),
+ notification.silent(),
+ notification_data.obj());
RegeneratedNotificationInfo notification_info(
notification.replace_id(), platform_id,

Powered by Google App Engine
This is Rietveld 408576698