Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 965403003: Making WebRTC quality tests less dependent on installed tools. (Closed)

Created:
5 years, 9 months ago by phoglund_chromium
Modified:
5 years, 9 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Making WebRTC quality tests less dependent on installed tools. This patch: 1) groups all tools for the audio and video quality tests per platform. 2) adds ffmpeg and zxing to the private tool bucket for all platforms. 3) updates the tests to the new tool locations. This must land at the same time as a webrtc.DEPS CL which makes the download step --recursive and --auto_platform for the private tool bucket. Left to fix: 1) The AQ test is still dependent on installed sox on mac/linux. BUG=440387 Committed: https://crrev.com/6dcda57d0800cd1347c63545bc3bb15f250ae716 Cr-Commit-Position: refs/heads/master@{#318851}

Patch Set 1 #

Patch Set 2 : Minor win fixes, improved error msg for rbga->i420, frame_analyzer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -17 lines) Patch
M chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 4 chunks +5 lines, -13 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc View 1 4 chunks +21 lines, -4 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_common.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_common.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
D chrome/test/data/webrtc/resources/tools/libgomp-1.dll.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/test/data/webrtc/resources/tools/linux/ffmpeg.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/test/data/webrtc/resources/tools/linux/pesq.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/linux/zxing.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/mac/ffmpeg.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/test/data/webrtc/resources/tools/mac/pesq.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/mac/zxing.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/test/data/webrtc/resources/tools/pesq.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/webrtc/resources/tools/pesq.exe.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/webrtc/resources/tools/pesq_mac.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/webrtc/resources/tools/pthreadgc2.dll.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/webrtc/resources/tools/sox.exe.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygEMF-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygICE-6.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygMagick++-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygMagick++-5.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygMagickCore-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygMagickCore-5.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygMagickWand-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygMagickWand-5.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygSM-6.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygX11-6.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygXau-6.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygXaw-7.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygXdmcp-6.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygXext-6.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygXft-2.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygXmu-6.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygXpm-4.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygXrender-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygXt-6.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygattr-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygautotrace-3.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygbz2-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygcairo-2.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygcairo-gobject-2.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygcairo-script-interpreter-2.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygcharset-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygcroco-0.6-3.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygcrypt-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygcrypto-0.9.8.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygcrypto-1.0.0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygdatrie-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygdb-4.5.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygdb_cxx-4.5.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygdbus-1-3.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygexpat-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygfam-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygffi-4.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygfftw3-3.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygfftw3_threads-3.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygfftw3f-3.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygfftw3f_threads-3.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygfontconfig-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygform-10.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygformw-10.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygfpx-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygfreetype-6.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cyggcc_s-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cyggd-2.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cyggdbm-4.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cyggdbm_compat-4.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cyggdk_pixbuf-2.0-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cyggif-4.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cyggio-2.0-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygglib-2.0-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cyggmodule-2.0-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cyggmp-3.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cyggobject-2.0-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cyggomp-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cyggraphite2-3.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cyggs-9.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cyggthread-2.0-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygharfbuzz-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cyghistory7.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygicons-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygiconv-2.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygicudata.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygicudata48.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygicui18n.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygicui18n48.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygicuio.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygicuio48.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygicule.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygicule48.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygiculx.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygiculx48.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygicutest.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygicutest48.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygicuuc.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygicuuc48.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygidn-11.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygintl-3.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygintl-8.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygjasper-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygjbig-2.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygjpeg-7.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygjpeg-8.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cyglcms-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cyglcms2-2.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cyglsa.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cyglsa64.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygltdl-7.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cyglzma-5.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygmagic-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygmenu-10.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygmenuw-10.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygming-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygmp-3.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygncurses++-10.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygncurses++w-10.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygncurses-10.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygncursesw-10.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygpanel-10.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygpanelw-10.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygpango-1.0-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygpangocairo-1.0-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygpangoft2-1.0-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygpangoxft-1.0-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygpaper-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygpcre-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygpcre-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygperl5_14.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygpixman-1-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygplotter-2.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygpng12.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygpng14-14.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygpng15-15.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygpopt-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygpstoedit-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygreadline7.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygrsvg-2-2.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygsigsegv-2.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygsqlite3-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygssl-0.9.8.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygssl-1.0.0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygssp-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygstdc++-6.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygthai-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygtic-10.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygticw-10.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygtiff-5.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygtiffxx-5.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cyguuid-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygwin1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygxcb-1.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygxcb-render-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygxcb-shm-0.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygxml2-2.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/cygz.dll.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/ffmpeg.exe.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/test/data/webrtc/resources/tools/win/libgomp-1.dll.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/webrtc/resources/tools/win/pesq.exe.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/webrtc/resources/tools/win/pthreadgc2.dll.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/webrtc/resources/tools/win/sox.exe.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/webrtc/resources/tools/win/zlib1.dll.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/win/zxing.exe.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/test/data/webrtc/resources/tools/zlib1.dll.sha1 View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
phoglund_chromium
5 years, 9 months ago (2015-03-02 12:31:45 UTC) #2
kjellander_chromium
Nice! lgtm
5 years, 9 months ago (2015-03-02 13:02:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965403003/20001
5 years, 9 months ago (2015-03-02 14:43:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965403003/20001
5 years, 9 months ago (2015-03-03 07:48:14 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-03 07:50:26 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 07:51:12 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6dcda57d0800cd1347c63545bc3bb15f250ae716
Cr-Commit-Position: refs/heads/master@{#318851}

Powered by Google App Engine
This is Rietveld 408576698