chrome/browser/media/webrtc_browsertest_common.h - Issue 965403003: Making WebRTC quality tests less dependent on installed tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/webrtc_browsertest_common.h

Issue 965403003: Making WebRTC quality tests less dependent on installed tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor win fixes, improved error msg for rbga->i420, frame_analyzer Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc ('k') | chrome/browser/media/webrtc_browsertest_common.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/webrtc_browsertest_common.h

diff --git a/chrome/browser/media/webrtc_browsertest_common.h b/chrome/browser/media/webrtc_browsertest_common.h

index 27ab604a5b4db860c530f4e4c813663563d93a89..40b99d3ecab0303c9ff91d7dcd85d322d9ef6375 100644

--- a/chrome/browser/media/webrtc_browsertest_common.h

+++ b/chrome/browser/media/webrtc_browsertest_common.h

@@ -31,6 +31,13 @@ bool HasYuvAndY4mFile(const base::FilePath::CharType* reference_file);

// Retrieves the reference files dir, to which file names can be appended.

base::FilePath GetReferenceFilesDir();

+// Retrieves a tool binary path from chrome/test/data/webrtc/resources/tools,

+// according to platform. If we're running on Linux, requesting pesq will yield

+// chrome/test/data/webrtc/resources/tools/linux/pesq, whereas the same call on

+// Windows will yield chrome/test/data/webrtc/resources/tools/win/pesq.exe.

+// This function does not check the binary actually exists.

+base::FilePath GetToolForPlatform(const std::string& tool_name);

extern const base::FilePath::CharType kReferenceFileName360p[];

extern const base::FilePath::CharType kReferenceFileName720p[];

extern const base::FilePath::CharType kYuvFileExtension[];