Making WebRTC quality tests less dependent on installed tools.

chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <ctime>
 
 #include "base/command_line.h"
 #include "base/files/file_enumerator.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
@@ skipping 59 matching lines @@
 //    <Monitor of x>, where x is whatever your primary sound device is called.
 // 6. Try launching chrome as the target user on the target machine, try
 //    playing, say, a YouTube video, and record with # arecord -f dat tmp.dat.
 //    Verify the recording with aplay (should have recorded what you played
 //    from chrome).
 //
 // Note: the volume for ALL your input devices will be forced to 100% by
 //       running this test on Linux.
 //
 // On Mac:
+// TODO(phoglund): download sox from gs instead.
 // 1. Get SoundFlower: http://rogueamoeba.com/freebies/soundflower/download.php
 // 2. Install it + reboot.
 // 3. Install MacPorts (http://www.macports.org/).
 // 4. Install sox: sudo port install sox.
 // 5. (For Chrome bots) Ensure sox and rec are reachable from the env the test
 //    executes in (sox and rec tends to install in /opt/, which generally isn't
 //    in the Chrome bots' env). For instance, run
 //    sudo ln -s /opt/local/bin/rec /usr/local/bin/rec
 //    sudo ln -s /opt/local/bin/sox /usr/local/bin/sox
 // 6. In Sound Preferences, set both input and output to Soundflower (2ch).
@@ skipping 207 matching lines @@
     }
   }
 #endif
   return true;
 }
 
 // Sox is the "Swiss army knife" of audio processing. We mainly use it for
 // silence trimming. See http://sox.sourceforge.net.
 base::CommandLine MakeSoxCommandLine() {
 #if defined(OS_WIN)
-  base::FilePath sox_path = test::GetReferenceFilesDir().Append(
-      FILE_PATH_LITERAL("tools/sox.exe"));
+  base::FilePath sox_path = test::GetToolForPlatform("sox");
   if (!base::PathExists(sox_path)) {
     LOG(ERROR) << "Missing sox.exe binary in " << sox_path.value()
                << "; you may have to provide this binary yourself.";
     return base::CommandLine(base::CommandLine::NO_PROGRAM);
   }
   base::CommandLine command_line(sox_path);
 #else
+  // TODO(phoglund): call checked-in sox rather than system sox on mac/linux.
+  // Same for rec invocations on Mac, above.
   base::CommandLine command_line(base::FilePath(FILE_PATH_LITERAL("sox")));
 #endif
   return command_line;
 }
 
 // Removes silence from beginning and end of the |input_audio_file| and writes
 // the result to the |output_audio_file|. Returns true on success.
 bool RemoveSilence(const base::FilePath& input_file,
                    const base::FilePath& output_file) {
   // SOX documentation for silence command: http://sox.sourceforge.net/sox.html
@@ skipping 85 matching lines @@
 // The raw score in MOS is written to |raw_mos|, whereas the MOS-LQO score is
 // written to mos_lqo. The scores are returned as floats in string form (e.g.
 // "3.145", etc). Returns true on success.
 bool RunPesq(const base::FilePath& reference_file,
              const base::FilePath& actual_file,
              int sample_rate, std::string* raw_mos, std::string* mos_lqo) {
   // PESQ will break if the paths are too long (!).
   EXPECT_LT(reference_file.value().length(), 128u);
   EXPECT_LT(actual_file.value().length(), 128u);
 
-#if defined(OS_WIN)
-  base::FilePath pesq_path =
-      test::GetReferenceFilesDir().Append(FILE_PATH_LITERAL("tools/pesq.exe"));
-#elif defined(OS_MACOSX)
-  base::FilePath pesq_path =
-      test::GetReferenceFilesDir().Append(FILE_PATH_LITERAL("tools/pesq_mac"));
-#else
-  base::FilePath pesq_path =
-      test::GetReferenceFilesDir().Append(FILE_PATH_LITERAL("tools/pesq"));
-#endif
-
+  base::FilePath pesq_path = test::GetToolForPlatform("pesq");
   if (!base::PathExists(pesq_path)) {
     LOG(ERROR) << "Missing PESQ binary in " << pesq_path.value()
                << "; you may have to provide this binary yourself.";
     return false;
   }
 
   base::CommandLine command_line(pesq_path);
   command_line.AppendArg(base::StringPrintf("+%d", sample_rate));
   command_line.AppendArgPath(reference_file);
   command_line.AppendArgPath(actual_file);
@@ skipping 332 matching lines @@
 #endif
 
 // Since the AGC is off here there should be no gain at all.
 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioQualityBrowserTest,
                        MAYBE_MANUAL_TestAutoGainIsOffWithAudioProcessingOff) {
   const char* kAudioCallWithoutAudioProcessing =
       "{audio: { mandatory: { echoCancellation: false } } }";
   ASSERT_NO_FATAL_FAILURE(TestAutoGainControl(
       kReferenceFile, kAudioCallWithoutAudioProcessing, "_no_agc"));
 }