tools/gn/scope_per_file_provider.h - Issue 964203002: tools/gn: Fix errors found by Facebook's flint tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/scope_per_file_provider.h

Issue 964203002: tools/gn: Fix errors found by Facebook's flint tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix chromium-style plugin errors Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/scope_per_file_provider.h

diff --git a/tools/gn/scope_per_file_provider.h b/tools/gn/scope_per_file_provider.h

index 8f9c5539f838925352bbd726a8667003de6ef826..fb6d62f405fde250de2d718c4d980d7a87142514 100644

--- a/tools/gn/scope_per_file_provider.h

+++ b/tools/gn/scope_per_file_provider.h

@@ -18,7 +18,7 @@ class ScopePerFileProvider : public Scope::ProgrammaticProvider {

// When allow_target_vars is unset, the target-related values will be

// undefined to GN script.

ScopePerFileProvider(Scope* scope, bool allow_target_vars);

- virtual ~ScopePerFileProvider();

+ ~ScopePerFileProvider() override;

// ProgrammaticProvider implementation.

const Value* GetProgrammaticValue(const base::StringPiece& ident) override;

« no previous file with comments | « tools/gn/scope.cc ('k') | tools/gn/setup.h » ('j') | no next file with comments »