tools/gn/setup.h - Issue 964203002: tools/gn: Fix errors found by Facebook's flint tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/setup.h

Issue 964203002: tools/gn: Fix errors found by Facebook's flint tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix chromium-style plugin errors Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/setup.h

diff --git a/tools/gn/setup.h b/tools/gn/setup.h

index 444805964e4f7573513aa561acd7bacf87df7f8c..e3607503f1f9e9c4135c54b344e34a9d5b6d4359 100644

--- a/tools/gn/setup.h

+++ b/tools/gn/setup.h

@@ -210,8 +210,8 @@ class DependentSetup : public CommonSetup {

// Note: this could be one function that takes a CommonSetup*, but then

// the compiler can get confused what to call, since it also matches the

// default copy constructor.

- DependentSetup(Setup* derive_from);

- DependentSetup(DependentSetup* derive_from);

+ explicit DependentSetup(Setup* derive_from);

+ explicit DependentSetup(DependentSetup* derive_from);

~DependentSetup() override;

// These are the two parts of Run() in the regular setup, not including the

« no previous file with comments | « tools/gn/scope_per_file_provider.h ('k') | tools/gn/standard_out.cc » ('j') | no next file with comments »