tools/gn/scope.cc - Issue 964203002: tools/gn: Fix errors found by Facebook's flint tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/scope.cc

Issue 964203002: tools/gn: Fix errors found by Facebook's flint tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix chromium-style plugin errors Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/scope.cc

diff --git a/tools/gn/scope.cc b/tools/gn/scope.cc

index cd5bd604f37fc466c06d30be15defe15e4d60ed5..bee4ce0aa2dedc766c6fe7b34faea55fd0c1554d 100644

--- a/tools/gn/scope.cc

+++ b/tools/gn/scope.cc

@@ -25,6 +25,11 @@ bool IsPrivateVar(const base::StringPiece& name) {

} // namespace

+Scope::ProgrammaticProvider::~ProgrammaticProvider() {

+ scope_->RemoveProvider(this);

Scope::Scope(const Settings* settings)

: const_containing_(nullptr),

mutable_containing_(nullptr),

« no previous file with comments | « tools/gn/scope.h ('k') | tools/gn/scope_per_file_provider.h » ('j') | no next file with comments »