Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 963903002: ui: Make InProcess context on-screen if it has a window. (Closed)

Created:
5 years, 9 months ago by danakj
Modified:
5 years, 9 months ago
Reviewers:
tfarina, piman
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Make InProcess context on-screen if it has a window. This makes aura_demo output show up. R=piman@chromium.org BUG=462739 Committed: https://crrev.com/1e1c901cbd1d8c62fac3dea47f8dde52d94fe42c Cr-Commit-Position: refs/heads/master@{#318549}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M ui/compositor/test/in_process_context_provider.cc View 1 chunk +7 lines, -12 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
danakj
5 years, 9 months ago (2015-02-27 22:24:41 UTC) #1
piman
LGTM, thanks a lot.
5 years, 9 months ago (2015-02-27 22:27:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963903002/1
5 years, 9 months ago (2015-02-27 22:29:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-27 23:47:45 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1e1c901cbd1d8c62fac3dea47f8dde52d94fe42c Cr-Commit-Position: refs/heads/master@{#318549}
5 years, 9 months ago (2015-02-27 23:48:21 UTC) #6
tfarina
lgtm https://codereview.chromium.org/963903002/diff/1/ui/compositor/test/in_process_context_provider.cc File ui/compositor/test/in_process_context_provider.cc (right): https://codereview.chromium.org/963903002/diff/1/ui/compositor/test/in_process_context_provider.cc#newcode99 ui/compositor/test/in_process_context_provider.cc:99: window_, gfx::Size(1, 1), nullptr, /* share_context */ I ...
5 years, 9 months ago (2015-02-28 00:19:28 UTC) #8
danakj
5 years, 9 months ago (2015-02-28 00:21:09 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/963903002/diff/1/ui/compositor/test/in_proces...
File ui/compositor/test/in_process_context_provider.cc (right):

https://codereview.chromium.org/963903002/diff/1/ui/compositor/test/in_proces...
ui/compositor/test/in_process_context_provider.cc:99: window_, gfx::Size(1, 1),
nullptr, /* share_context */
On 2015/02/28 00:19:28, tfarina wrote:
> I know this is was formatted by clang. But one arg per line is much
> better/readable imo!

i don't disagree.

Powered by Google App Engine
This is Rietveld 408576698