Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: ui/compositor/test/in_process_context_provider.cc

Issue 963903002: ui: Make InProcess context on-screen if it has a window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/compositor/test/in_process_context_provider.cc
diff --git a/ui/compositor/test/in_process_context_provider.cc b/ui/compositor/test/in_process_context_provider.cc
index 18978b51ab4df66ff5a84b116d861845d253bda5..d59736ff86d2730a1cf6cb39897fe317b73bd4f4 100644
--- a/ui/compositor/test/in_process_context_provider.cc
+++ b/ui/compositor/test/in_process_context_provider.cc
@@ -93,18 +93,13 @@ bool InProcessContextProvider::BindToCurrentThread() {
if (!context_) {
gfx::GpuPreference gpu_preference = gfx::PreferDiscreteGpu;
context_.reset(gpu::GLInProcessContext::Create(
- nullptr, /* service */
- nullptr, /* surface */
- true, /* is_offscreen */
- window_,
- gfx::Size(1, 1),
- nullptr, /* share_context */
- true, /* share_resources */
- attribs_,
- gpu_preference,
- gpu::GLInProcessContextSharedMemoryLimits(),
- nullptr,
- nullptr));
+ nullptr, /* service */
+ nullptr, /* surface */
+ !window_, /* is_offscreen */
+ window_, gfx::Size(1, 1), nullptr, /* share_context */
tfarina 2015/02/28 00:19:28 I know this is was formatted by clang. But one arg
danakj 2015/02/28 00:21:09 i don't disagree.
+ true, /* share_resources */
+ attribs_, gpu_preference, gpu::GLInProcessContextSharedMemoryLimits(),
+ nullptr, nullptr));
if (!context_)
return false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698